Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails with GitHub Actions ubuntu-24.04 and .NET 9 SDK #112

Closed
Methuselah96 opened this issue Dec 9, 2024 · 8 comments
Closed

Fails with GitHub Actions ubuntu-24.04 and .NET 9 SDK #112

Methuselah96 opened this issue Dec 9, 2024 · 8 comments

Comments

@Methuselah96
Copy link

Methuselah96 commented Dec 9, 2024

The CLI seems to be having trouble with ubuntu-24.04 in combination with the .NET 9 SDK on GitHub Actions:

image

The ubuntu-24.04 is being rolled out as ubuntu-latest over the next month. It looks like MSBuild is not installed by default in 24.04. I would expect MSBuildLocator to pick up on the MSBuild version included with the .NET SDK, but I suspect that this might not be working because I'm using .NET 9 SDK, and this project is still on .NET 8.

I'm hoping #109 might fix this, but I'm not totally sure.

@Methuselah96 Methuselah96 changed the title Fails with GitHub Actions ubuntu-24.04 Fails with GitHub Actions ubuntu-24.04 and .NET 9 SDK Dec 9, 2024
@leonardochaia
Copy link
Owner

Hi @Methuselah96 thanks for reaching out.
We are working on getting dotnet-affected to pass tests on .NET 9 but are having issues related to MSBuild as well.

Can you attach the dotnet --info output as well for completeness?

If you want to give it a go to the dotnet 9 compatible version, you can get the packages from this build and use those instead of the nuget.org version.

Thank you,
Leo.

@Methuselah96
Copy link
Author

Here is the dotnet --info output:

.NET SDK:
 Version:           9.0.101
 Commit:            eedb237549
 Workload version:  9.0.100-manifests.3068a692
 MSBuild version:   17.12.12+1cce77968

Runtime Environment:
 OS Name:     ubuntu
 OS Version:  24.04
 OS Platform: Linux
 RID:         linux-x64
 Base Path:   /usr/share/dotnet/sdk/9.0.101/

.NET workloads installed:
There are no installed workloads to display.
Configured to use loose manifests when installing new manifests.

Host:
  Version:      9.0.0
  Architecture: x64
  Commit:       9d5a6a9aa4

.NET SDKs installed:
  9.0.101 [/usr/share/dotnet/sdk]

.NET runtimes installed:
  Microsoft.AspNetCore.App 9.0.0 [/usr/share/dotnet/shared/Microsoft.AspNetCore.App]
  Microsoft.NETCore.App 8.0.11 [/usr/share/dotnet/shared/Microsoft.NETCore.App]
  Microsoft.NETCore.App 9.0.0 [/usr/share/dotnet/shared/Microsoft.NETCore.App]

Other architectures found:
  None

Environment variables:
  DOTNET_ROOT       [/usr/share/dotnet]

global.json file:
  Not found

@leonardochaia
Copy link
Owner

Hi @Methuselah96 , dotnet affected v6.0.0-preview-1 has just been released would you kindly give it a go and report back?
Thank you.
Leo

@Methuselah96
Copy link
Author

That seems to have fixed it. Thanks!

@leonardochaia
Copy link
Owner

Got it, I'll close this one. Feel free to reopen as needed.
Thanks!
Leo.

@Methuselah96
Copy link
Author

@leonardochaia Any idea on when a stable version of v6 will be released? There's no convenient way for me to use the prerelease since I'm using dotnet-affected-action.

@Methuselah96
Copy link
Author

Methuselah96 commented Jan 8, 2025

Oh, I guess I can specify toolVersion for the GitHub Action. Regardless, I look forward to the sable release of v6. Any ideas when it will become stable?

@dojoel
Copy link

dojoel commented Feb 11, 2025

@leonardochaia Just checking in to see if you have a timeline for a stable v6 release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants