Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that duplicate resources at different scale levels aren't in the same pak file #32

Open
GoogleCodeExporter opened this issue Jul 8, 2015 · 2 comments

Comments

@GoogleCodeExporter
Copy link

(As talked about on IM with thakis@.)

Chrome has multiple resource paks for different purposes. There is a set of 
{default,touch}_{100,200,300,...}.pak files which contain data which is 
supposed to be keyed to certain properties of the display, and a normal 
resource.pak which is a supposed to be used for items which aren't display 
dependent.

It is entirely possible to enter a world of pain by unintentionally mixing 
these two concepts. Given that the definitions for, ie, the chrome_html and 
chrome_scaled_image structures live in grit, maybe a warning or error could be 
emitted if there's mixing of a chrome_scaled_image structure and a normal, 
non-image include?

This may not be possible (or adding this here might be the wrong architectural 
layer).

Original issue reported on code.google.com by [email protected] on 13 Apr 2015 at 11:51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant