Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No sign for required curl version. #1119

Closed
GitSparTV opened this issue Oct 1, 2024 · 2 comments · Fixed by #1120
Closed

No sign for required curl version. #1119

GitSparTV opened this issue Oct 1, 2024 · 2 comments · Fixed by #1120
Assignees
Labels
Milestone

Comments

@GitSparTV
Copy link

GitSparTV commented Oct 1, 2024

Description

On ubuntu 22.04 the latest curl is 7.81.0. I get no warnings but a compilation error:

/cpr/cpr/error.cpp:131:14: error: use of undeclared identifier 'CURLE_UNRECOVERABLE_POLL'
  131 |         case CURLE_UNRECOVERABLE_POLL:
      |              ^
/cpr/cpr/error.cpp:133:14: error: use of undeclared identifier 'CURLE_TOO_LARGE'
  133 |         case CURLE_TOO_LARGE:
      |              ^
2 errors generated.

Example/How to Reproduce

install curl from apt on ubuntu and try cmake .. -DCPR_USE_SYSTEM_CURL=ON -DBUILD_SHARED_LIBS=OFF && cmake --build .

Possible Fix

Tell the supported version in README or make a check in CMake or make macro check for curl version in the code

Where did you get it from?

GitHub (branch e.g. master)

Additional Context/Your Environment

  • OS: Ubuntu
  • Version: 22.04 (Docker)
@COM8
Copy link
Member

COM8 commented Oct 3, 2024

Thanks for reporting!
I need to go through all errors and add version checks.

@COM8 COM8 linked a pull request Oct 6, 2024 that will close this issue
@COM8
Copy link
Member

COM8 commented Oct 6, 2024

Fixed in #1120 and will be included in Release 1.11.0 and 1.9.8

@COM8 COM8 self-assigned this Oct 6, 2024
@COM8 COM8 closed this as completed in #1120 Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants