-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BLD: error while building from source on Mac amd64 #141
Comments
fixed in liberfa/erfa#101 |
I can't even reproduce locally today, so let's just close this. |
I hit the same error when compiling for Android:
It's probably caused by this code: Lines 122 to 132 in 12b938e
If the configure script fails for any reason at all, then setup.py will generate the config.h file in a different way, which includes quotes around the version numbers. |
interesting, then I guess we should re-open. |
Any failure in the configure script should hit this problem, so |
I'm having a hard time figuring out where to hook this up in the build process since so much of it is code generation and the configure script itself ( |
|
Here's what I've been trying diff --git a/configure.ac b/configure.ac
index a3dc59b..e763b5d 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1,5 +1,5 @@
# Process this file with autoconf to produce a configure script.
-
+exit 1
AC_PREREQ([2.68])
## Follow the instructions in RELEASE.rst to change package version
AC_INIT([erfa],[2.0.1]) but this doesn't fail as expected. In fact, it doesn't prevent building at all on my system (even from a clean slate) |
in fact here's my whole test script set -euxo pipefail
rm -fr pyerfa || true
git clone https://github.com/liberfa/pyerfa
pushd pyerfa
git submodule update --init
uv venv -p 3.13
pushd liberfa/erfa
git apply ../../../patch
popd
uv build
popd where |
Ah, it looks like this was actually fixed in #155, but there hasn't been a release since then. |
🤦🏻♂️ I forgot about that. Well, up to maintainers to decide if this should be closed again or if we should keep it open as long as there is no release with the fix |
Since I made a new release, this should be fixed. Let's hope it remains so! |
I noticed earlier this week that the following command started failing on my platform
Error details
I don't quite get what's happening yet, and it's possible that it's really just showing something is broken in my setup, but I cannot pin point it for now. It's kinda blocking my personal workflow to test astropy with numpy dev locally, so I do have an incentive to inspect and fix this myself :)
The text was updated successfully, but these errors were encountered: