Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metrics movingAverages getter not returning a proper clone #898

Closed
vasco-santos opened this issue Mar 9, 2021 · 2 comments
Closed

Metrics movingAverages getter not returning a proper clone #898

vasco-santos opened this issue Mar 9, 2021 · 2 comments
Labels
exp/beginner Can be confidently tackled by newcomers good first issue Good issue for new contributors kind/bug A bug in existing code (including security flaws) P3 Low: Not priority right now status/ready Ready to be worked

Comments

@vasco-santos
Copy link
Member

https://github.com/libp2p/js-libp2p/blob/v0.30.9/src/metrics/stats.js#L87

A manual clone should be created. Referenced in #897 (comment)
@vasco-santos vasco-santos added kind/bug A bug in existing code (including security flaws) exp/novice Someone with a little familiarity can pick up status/ready Ready to be worked labels Mar 9, 2021
@vasco-santos vasco-santos mentioned this issue Mar 9, 2021
Merged
@vasco-santos vasco-santos added the P3 Low: Not priority right now label Mar 15, 2021
@vasco-santos vasco-santos added good first issue Good issue for new contributors exp/beginner Can be confidently tackled by newcomers and removed exp/novice Someone with a little familiarity can pick up labels Nov 12, 2021
@koozcoo
Copy link

koozcoo commented Nov 26, 2021

Hello, is this issue still relevant ? I am interested to be involved in this repo. Is there any live chat where we can discuss such things ? The discord invite seems outdated and on matrix #libp2p I can't reach anyone related to this project. Thank you

@maschad
Copy link
Member

maschad commented Sep 28, 2023

Closing as this no longer relevant

@maschad maschad closed this as completed Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
exp/beginner Can be confidently tackled by newcomers good first issue Good issue for new contributors kind/bug A bug in existing code (including security flaws) P3 Low: Not priority right now status/ready Ready to be worked
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vasco-santos @maschad @koozcoo