Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Websocket connection simultaneously to the Session connect #322

Open
devgianlu opened this issue Feb 28, 2021 · 5 comments
Open

Run Websocket connection simultaneously to the Session connect #322

devgianlu opened this issue Feb 28, 2021 · 5 comments
Labels
enhancement New feature or request

Comments

@devgianlu
Copy link
Member

devgianlu commented Feb 28, 2021

With the login5 token endpoint we can save time in the startup time by requesting a token via login5 and use it to start the websocket along with the REST API, we can then start the internal Hermes connection using the same token or with username/password.

The Hermes API should be used as little as possible as it's not going to live in the future. This probably addresses #308 partially.

@devgianlu devgianlu added the enhancement New feature or request label Feb 28, 2021
@sashahilton00
Copy link
Member

Someone asked be earlier about loginv5, I don't suppose you've looked into it to see how the hashcash stuff is solved? Also, after opening the issue a few days back about updating the protobuf definitions, I poked around in the latest client, and a significant number of the calls that were being made over Hermes have been moved to HTTP. I'm hoping to have time to start writing things up in the coming days

@devgianlu
Copy link
Member Author

@sashahilton00 I have indeed figured out how the hashcash is solved. Just haven't published it anywhere since it was useless for out user case until today I come up with this idea that could help in some way.

I've been inspecting the Hermes requests too, but I think all I do with Hermes in this library hasn't moved. I should probably double check all the requests I am making.

@PouleR
Copy link

PouleR commented Apr 22, 2021

@sashahilton00 I have indeed figured out how the hashcash is solved. Just haven't published it anywhere since it was useless for out use until today I come up with this idea that could help in some way.

I've been inspecting the Hermes requests too, but I think all I do with Hermes in this library hasn't moved. I should probably double check all the requests I am making.

Hi @devgianlu, maybe this is the wrong issue to ask; but can you maybe share the knowledge about the HashCash?

I’m working on a PHP application for the Spotify Artists data and I am using the proto files from this repository. Just to generate all the entities needed for the login5 API. However now I’m struggling to get the actual token since the 2nd request should contain the hashcash if I’m correct.

devgianlu added a commit that referenced this issue Apr 24, 2021
@PouleR
Copy link

PouleR commented Apr 24, 2021

@devgianlu wow thanks a lot! I’m going to use this to port it to a PHP bundle.

Thanks! Much appreciated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants