Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue pfls event to metadata pipe when pausing, stopping or changing tracks #325

Closed
aleszczynskig opened this issue Mar 10, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@aleszczynskig
Copy link

aleszczynskig commented Mar 10, 2021

Is your feature request related to a problem? Please describe.
Can you issue a pfls command to the shairport-sync style metadata pipe when either pausing, stopping or changing track. This enables forked-daapd to immediately pause as opposed to a significant delay or 4-5 seconds before the command is observed in forked-daapd due to the audio stream ending. I have requested @ejurgensen to implement this feature in forked-daapd which has been done (see issue 295). Many thanks.

Describe the solution you'd like
Issue a 'pfls' event to the configured metadata pipe when pausing, stopping or changing track.

Describe alternatives you've considered
None

Additional context
The command required to be issued is <item><type>73736e63</type><code>70666C73</code><length>0</length></item>

@aleszczynskig aleszczynskig added the enhancement New feature or request label Mar 10, 2021
@devgianlu
Copy link
Member

What is <item><type>73736e63</type><code>70666C73</code><length>0</length></item> for? Pause, stop or track change?

@aleszczynskig
Copy link
Author

It's the pfls command. It instructs forked-daapd to drop the content on the audio buffer (which removes the lag). So the same command can be issued for all of them.

Thanks for looking at this.

@devgianlu
Copy link
Member

Got it. Let me know if it works

@aleszczynskig
Copy link
Author

This is working exactly as expected. Thank you for the quick fix. When using librespot-java with forked-daapd, the controls are really responsive.

I will close the ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants