Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start verifying gossip data via bitcoind RPC #428

Open
wants to merge 25 commits into
base: main
Choose a base branch
from

Conversation

tnull
Copy link
Collaborator

@tnull tnull commented Jan 7, 2025

Based on #426.
Closes #377.

So far, we did not verify gossip data received via the peer-to-peer network. As a small fix in the latest LDK release allows us properly set the gossip verifier, we do so, and start verifying gossip when the bitcoind RPC gossip source is set.

tnull added 24 commits January 6, 2025 11:06
.. and updates to `Cargo.toml`
.. for now by igoring it. Will properly address them in a follow-up
.. we pin `rustls` for now to make CI pass, but mid-term we want to
figure out a new MSRV target to bump to.
Previously, we decided to continue parsing any fields if we failed to
parse a known (i.e., `lightning` or `lno`) parameter failed to parse.
This however just hides the error and is a bit anti-idiomatic even
though allowing to use *some* URI fields even in the face of
incompatible formats for others.

Here we therefore opt to fail parsing the URI if any field fails.
@tnull tnull added this to the 0.5 milestone Jan 7, 2025
So far, we did not verify gossip data received via the peer-to-peer
network. As a small fix in the latest LDK release allows us properly set
the gossip verifier, we do so, and start verifying gossip when the
bitcoind RPC gossip source is set.
@tnull tnull force-pushed the 2025-01-start-verifying-gossip branch from a1ce26e to d4626f8 Compare January 7, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Start verifying gossip for the bitcoind RPC backend
1 participant