Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next major roadmap #338

Closed
10 tasks done
soullivaneuh opened this issue Nov 1, 2017 · 15 comments
Closed
10 tasks done

Next major roadmap #338

soullivaneuh opened this issue Nov 1, 2017 · 15 comments
Labels
Milestone

Comments

@soullivaneuh
Copy link
Contributor

soullivaneuh commented Nov 1, 2017

According to #337 (comment), here is a roadmap for the next 2.0 major of this bundle:

This are ideas I got right know. Feel free to comment if you want to add/modify/remove any of them.

Also, feel free to participate to this next major. 👍

@alexislefebvre
Copy link
Collaborator

Note that there is another roadmap in #332.

@soullivaneuh
Copy link
Contributor Author

Yeah I saw it later, but not quite the same.

Thanks for linking it. 👍

@Jean85
Copy link
Contributor

Jean85 commented Nov 13, 2017

I would add supporting Symfony as ^3.0||^4.0 which would help most people with no big problems on our side. If the maintainers are 👍 with this issue, I would ask them to open a branch for this, I would gladly help.

@soullivaneuh
Copy link
Contributor Author

@Jean85 ^3.4 || ^4.0 is preferable IMHO, we don't have to support EOL version of Symfony on the next major.

@Jean85
Copy link
Contributor

Jean85 commented Nov 13, 2017

I know, but since we're talking about Symfony, we could impact a great deal of upgrade issues, since it will drag any Symfony component with it. I would prefer to bump it upwards from ^3.0 only if needed; due to their nice BC promise we could have no issues with that.

@soullivaneuh
Copy link
Contributor Author

due to their nice BC promise we could have no issues with that.

Well, we generally have to make BC trick on library. For example, if we want to use a method introduce in v3.2, we have to make the usage conditional with support of ^3.0.

As you said, there is a BC promise, but for end user. And to complete your sentence, the end user may upgrade to Symfony 3.4 without any issue. 😉

@alexislefebvre alexislefebvre added this to the 2.0 milestone Dec 4, 2017
@Jean85
Copy link
Contributor

Jean85 commented Dec 22, 2017

I've opened #359 to start development of this issue. Obviously a lot of tests are failing, but it's a starting point...

Can we add a tool for automatic CS fixing in this roadmap?

@soullivaneuh
Copy link
Contributor Author

Can we add a tool for automatic CS fixing in this roadmap?

@Jean85 Funny to ask, I made one recently: https://flintci.io

May we try it? 😄

@Jean85
Copy link
Contributor

Jean85 commented Jan 10, 2018

Eheh 😄 we should ask @lsmith77 ...
BTW, can you update the checklist, since #365 got merged?

@lsmith77
Copy link
Contributor

I like automation and I do not have any strong preferences .. I used https://styleci.io in the past and liked it. but I am fine trying out something new.

@soullivaneuh
Copy link
Contributor Author

@lsmith77 The only lack of StyleCI for me is the absence of cli fix possibilities. This is why I made a bridge but this one is not compatible with php-cs-fixer v2 anymore. I'll try a PR for that. 👍

BTW, can you update the checklist, since #365 got merged?

@Jean85 Sorry but I don't see which point this PR solve. 😕

@alexislefebvre
Copy link
Collaborator

alexislefebvre commented Jan 10, 2018

I think that the biggest challenge will be the compatibility with Alice, work has begun in #297, #321 and #337 and I have no idea about a solution. Help is welcome!

@Jean85
Copy link
Contributor

Jean85 commented Jan 11, 2018

Before solving those, IMHO we should get the build to green in #366, so we can define the range of deps that we want/are able to support...

@soullivaneuh, @alexislefebvre are you able to help me?

@alexislefebvre
Copy link
Collaborator

I think that we should add a note about the 2.x and master in order to explain that new features should go to 2.x. And that this version is still under development.

nelmio/alice use something like this:

2.x is in maintenance mode: PRs are accepted, but no active development is done on it by the maintainers any longer.

We'll also need to explain all the BC changes in order to ease the upgrade to 2.x.

@soullivaneuh
Copy link
Contributor Author

This issue is completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants