Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't compare full executed block to determine whether there was a conflict. #3172

Open
afck opened this issue Jan 23, 2025 · 0 comments
Open
Milestone

Comments

@afck
Copy link
Contributor

afck commented Jan 23, 2025

With #3164, the execution outcome can depend on the current round.

If this oracle is used, we shouldn't try to discern ExecuteBlockOutcome::Executed from ExecuteBlockOutcome::Conflict by comparing the exact executed block.

One alternative is to check that the ProposedBlock matches (i.e. the operations and messages are the ones we were meaning to commit) and that we are the block's signer. (#456 might be a prerequisite for doing that.)

@afck afck added this to the Mainnet milestone Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant