Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit number of pending blobs. #3203

Open
afck opened this issue Jan 29, 2025 · 6 comments
Open

Limit number of pending blobs. #3203

afck opened this issue Jan 29, 2025 · 6 comments

Comments

@afck
Copy link
Contributor

afck commented Jan 29, 2025

In permissionless chains, anyone can upload proposals and supply pending blobs.

We should limit the number of PendingBlobsViews per chain.

Re-proposals of validated blocks should be preferred. And we need to make sure that a chain can't be bricked because of too many PendingBlobsViews: It must always be possible to make a new successful proposal.

@afck afck changed the title Limit total pending blob size. Limit number of pending blobs. Jan 30, 2025
@malboro3435

This comment was marked as spam.

@Utso123

This comment was marked as spam.

@tufinger

This comment was marked as spam.

afck added a commit that referenced this issue Feb 1, 2025
## Motivation

Including blobs with the gRPC message that contains a block proposal or
certificate severely limits the total size of the blobs. (See
#3048.)

## Proposal

Remove the `blobs` field from block proposals, and handle blobs
separately, with one message each.

I added a `maximum_published_blobs` limit per block, and limited the
number of pending proposals with blobs to 1 for permissionless chains.
(See #3203.)

## Test Plan

The tests have been updated where necessary. Otherwise they already
cover different scenarios involving proposals with blobs.

## Release Plan

- Nothing to do / These changes follow the usual release cycle.

## Links

- Closes #3202
- [reviewer
checklist](https://github.com/linera-io/linera-protocol/blob/main/CONTRIBUTING.md#reviewer-checklist)
@luchkoolga21

This comment was marked as spam.

@ex001xp

This comment was marked as spam.

@Cave11

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants