Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make configurable which user identifier to use #5

Open
sauljabin opened this issue Oct 24, 2024 · 5 comments
Open

Make configurable which user identifier to use #5

sauljabin opened this issue Oct 24, 2024 · 5 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@sauljabin
Copy link
Member

We are using the claim: "sub" (subject that is the user id) to identify the users

image

image

Make this configurable, maybe we can use the preferred_username or email for this.

image

@sauljabin sauljabin added the enhancement New feature or request label Oct 24, 2024
@muhammadqamar muhammadqamar self-assigned this Oct 24, 2024
@sauljabin
Copy link
Member Author

@muhammadqamar @jhosep-marin @coltmcnealy-lh does it make sense? is this possible?

This is a spike, we can check if this makes sense in a research

@jhosep-marin
Copy link

I think we can try this, but in case we find it feasible, then we'll also have to consider changing how we are currently fetching userInfo from Keycloak's Admin API.

RIght now, fetching userInfo from Keycloak is as easy as this:
keycloak.realm(realm).users().get(userId).toRepresentation();
But that's because we are using the userId that comes from the sub claim in the accessToken.

@sauljabin sauljabin added the question Further information is requested label Oct 25, 2024
@sauljabin
Copy link
Member Author

@coltmcnealy-lh please your comments

@coltmcnealy-lh
Copy link
Member

@sauljabin this ticket is very high priority. Thank you for finding it. Let's put some effort into this to prioritize a better user experience.

@sauljabin
Copy link
Member Author

This is also applicable for groups (groups name instead of group id)

@hazimoarafa hazimoarafa transferred this issue from another repository Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants