Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCP Config Connector CRDs #1

Open
adnaan opened this issue May 27, 2022 · 4 comments
Open

GCP Config Connector CRDs #1

adnaan opened this issue May 27, 2022 · 4 comments

Comments

@adnaan
Copy link

adnaan commented May 27, 2022

Hi ! First of all, great work with deploykit. I am quite aligned on this approach have been using deploykit's k8s generated API here: https://github.com/dxcfg/dxcfg.

I see a potential use case to provision GCP resources using config connector CRDs. Would you be open to a contribution for that ?

@Yshayy
Copy link
Collaborator

Yshayy commented May 27, 2022

Thanks for the feedback :)

Be happy to accept PR, you can add sources here:
https://github.com/livecycle/deploykit/blob/199e95f53a10182df410523fc8f64b73a4f3cde3/generated/k8s/sources.json
And run the generate script. (If it doesn’t work, I can apply it as well)

I’ll publish a new version after the PR is merged

@adnaan
Copy link
Author

adnaan commented May 27, 2022

Its actually is a lot of CRD yamls in there: https://github.com/GoogleCloudPlatform/k8s-config-connector/tree/master/crds. And growing ! You are ok with the sources.json file getting a little crowded ? Alternatively I can keep it separate in its own json file.

@Yshayy
Copy link
Collaborator

Yshayy commented May 27, 2022

Hmm, maybe we can change the sources.json to sources.ts that exposes the sources object?
That way you can import other file that contains all the other crds and just “…” array spread it.

@adnaan
Copy link
Author

adnaan commented May 27, 2022

Makes sense. I will go with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants