Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

silo write support doesn't conform to current blueprint specs #808

Closed
cyrush opened this issue Aug 4, 2021 · 2 comments
Closed

silo write support doesn't conform to current blueprint specs #808

cyrush opened this issue Aug 4, 2021 · 2 comments
Labels
Milestone

Comments

@cyrush
Copy link
Member

cyrush commented Aug 4, 2021

This comment is 100% correct:

https://github.com/LLNL/conduit/blame/develop/src/libs/relay/conduit_relay_io_silo.cpp#L293

Silo support was added while the basic mesh blueprint was in flux, it needs to be reworked.

@cyrush cyrush added the bug label Aug 5, 2021
@cyrush cyrush added this to the 0.9.0 milestone Jan 29, 2022
@cyrush
Copy link
Member Author

cyrush commented Aug 22, 2023

@JustinPrivitera can we close this with your improvements?

@JustinPrivitera
Copy link
Member

I would expect yes. The problem is that the link up above no longer links to any comment, so it is unclear exactly what the original problem was.

@cyrush cyrush closed this as completed Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants