Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test job to the CI pipeline #121

Open
brh28 opened this issue Dec 13, 2024 · 2 comments
Open

Add test job to the CI pipeline #121

brh28 opened this issue Dec 13, 2024 · 2 comments
Assignees

Comments

@brh28
Copy link

brh28 commented Dec 13, 2024

Starting with #119, the test suite should now be in a passing state. Moving forward, we want to ensure new releases past this test suite and are being constantly maintained by executing the tests in the Concourse pipeline.

We can likely use Galoy as a reference since we're using the same test runner and make commands.

@brh28 brh28 self-assigned this Dec 16, 2024
@brh28
Copy link
Author

brh28 commented Jan 6, 2025

Good news: Unit tests job running succesfully: https://concourse.flashapp.me/teams/main/pipelines/flash-app/jobs/test-unit/builds/5.4

Bad news: Integration-tests appear to be more involved as the existing Galoy script (test-on-docker-host.sh) is configured to run on a remote GCP instance. Couple options I see:

  1. To follow Galoy's approach, we'd need to configure a GCP instance and share credentials
  2. To take our own approach, we could spin up an instance in DigitalOcean and change the scripts to run on it.

Either way, there's more complexity in running integration tests than originally expected.

@islandbitcoin let me know how you want to proceed

@brh28
Copy link
Author

brh28 commented Jan 7, 2025

Standup (1/7) - Look into option 2 above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant