Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload temp files to s3 in tear down #19

Closed
cnhappier opened this issue Jun 2, 2015 · 3 comments
Closed

Upload temp files to s3 in tear down #19

cnhappier opened this issue Jun 2, 2015 · 3 comments

Comments

@cnhappier
Copy link

In AWS environment, there's a way to make zero-download time upgrade, using the AWS auto scaling feature.
Details in here.
http://serverfault.com/questions/389301/amazon-ec2-elastic-load-balancing-strategy-for-zero-downtime-server-restart/679502#679502

So it's usual to close one EC2 instance and wait for the new one come to serve in the upgrade procedure.
In this situation, it's useful to upload the temp files to s3 when the s3 plugin is shutting down to avoid some log data missing after EC2 stop and terminate.

So it's nice to have a flag to enable this kind of "graceful shutdown" for this plugin.

@cnhappier
Copy link
Author

Pull request provided: #14

@barqshasbite
Copy link

I don't think this issue (and #68, and any other dupes) are valid anymore? The code was significantly refactored after this issue was reported and now the close method has this comment:

# The plugin has stopped receiving new events, but we still have
# data on disk, lets make sure it get to S3.

These issues and the related PRs can probably be closed.

@kares
Copy link
Contributor

kares commented Jun 14, 2022

as noted above, believe this is no longer valid with the current code in place (on plugin close)

@kares kares closed this as completed Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants