Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Touchstone fails when there is a slash in the branch name #125

Open
sbfnk opened this issue Oct 25, 2023 · 1 comment
Open

Touchstone fails when there is a slash in the branch name #125

sbfnk opened this issue Oct 25, 2023 · 1 comment

Comments

@sbfnk
Copy link
Contributor

sbfnk commented Oct 25, 2023

Failures might be occurring in multiple places because of the way touchstone relies on traversing paths for identifying branches but here's a reprex showing that this is an issue in benchmark_ls:

library("touchstone")
#> ✖ Could not find git repository from current working directory!
#> ℹ Please manually set the option "touchstone.git_root".

touchstone_clear()
branch <- "main"
atomic <- bench::mark(1 + 1, iterations = 1)
benchmark_write(atomic, name = "x", branch = branch)
## works with branch name "main"
benchmark_ls()
#> # A tibble: 1 × 2
#>   name  branch
#>   <chr> <chr> 
#> 1 x     main

touchstone_clear()
branch <- "test/branch"
atomic <- bench::mark(1 + 1, iterations = 1)
benchmark_write(atomic, name = "x", branch = branch)
## doesn't work with branch name "test/branch"
benchmark_ls()
#> # A tibble: 0 × 2
#> # ℹ 2 variables: name <chr>, branch <chr>

Created on 2023-10-25 with reprex v2.0.2

@lorenzwalthert
Copy link
Owner

Thanks for the detailed report. I currently don't have the capacity to fix this, but contributions are welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants