Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proactively go for feedback #97

Open
lorenzwalthert opened this issue Jan 14, 2022 · 13 comments
Open

Proactively go for feedback #97

lorenzwalthert opened this issue Jan 14, 2022 · 13 comments

Comments

@lorenzwalthert
Copy link
Owner

lorenzwalthert commented Jan 14, 2022

Identify repos that could benefit from {touchstone} and help them setting it up:

@lorenzwalthert lorenzwalthert changed the title Proactively good for feedback Proactively go for feedback Jan 14, 2022
@assignUser
Copy link
Collaborator

oh thats' a good idea!

@assignUser
Copy link
Collaborator

data.table has on open issue, should I go ahead and pitch {touchstone}? Or wait till after #95 is merged?

@lorenzwalthert
Copy link
Owner Author

Let's wait for #95. And then tell them we'll contribute it to ropensci and submit to CRAN 🥳

@mjskay
Copy link

mjskay commented Jan 14, 2022

FWIW --- I've been lurking on here awaiting your first CRAN release after which we'll probably try out using {touchstone} with {posterior} stan-dev/posterior#159. We definitely have need for it! :)

@assignUser
Copy link
Collaborator

Hey @mjskay thanks for dropping stealth 😄

As you probably have seen we are getting ready to submit to ropensci and afterwards CRAN, so our API should be pretty much stable by now. I would greatly appreciate any feedback on usability and function from a third party (currently @lorenzwalthert and I are the only users of the package afaik) prior to our CRAN release.

Maybe you can give it a try once #95 is merged?

@mjskay
Copy link

mjskay commented Jan 15, 2022

Thanks, it's good to know your intended timeline. If I have time (busy quarter atm) I'll give it a try after #95 is merged and let you know if I run into anything.

@lorenzwalthert
Copy link
Owner Author

lorenzwalthert commented Jan 15, 2022

The maintainers of {greta} also seem to be keen to try this out (greta-dev/greta#365).

@assignUser
Copy link
Collaborator

@lorenzwalthert I think we are now ready to go "Klinkenputzen", don't you think?

@lorenzwalthert
Copy link
Owner Author

I agree yes.

@lorenzwalthert
Copy link
Owner Author

@lorenzwalthert
Copy link
Owner Author

@assignUser
Copy link
Collaborator

@lorenzwalthert Ok looked into it, that is a side effect of the new optional trigger. Even if the workflow is skipped when an issue comment is created that does not contain /benchmark it still triggers the comment workflow that then has no idea whats happening and fails :D I'll open an issue and implement a fix

@lorenzwalthert
Copy link
Owner Author

Thanks for the quick response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants