Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added missing cocos.audio.SDL as SDL #336

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added missing cocos.audio.SDL as SDL #336

wants to merge 1 commit into from

Conversation

tushar5526
Copy link

closes #316

dangillet
dangillet requested changes Apr 16, 2023
View reviewed changes
Copy link
Contributor

@dangillet dangillet left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting this PR! I know it's been a long time since someone looked at this. 😄

Looking at other modules, it seems that the preferred method would be to import

from . import error

Then later on instead of SDL.error. we could simply write error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dangillet dangillet dangillet requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SDL not imported in timer.py
2 participants
@tushar5526 @dangillet