-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GF2int is a a global singleton and does not allow multiple RSCoder instances with different field generator polynomials. #6
Comments
Shorter example, without my helper functions:
which prints
The creation of |
Oh, I see the problem, they're using a singleton lookup table:
Bad. |
GF2int
is a a global singleton and does not allow multiple RSCoder instances with different field generator polynomials.
GF2int
is a a global singleton and does not allow multiple RSCoder instances with different field generator polynomials.
@jason-s Yes this is a leftover of the original implementation that I did not make. I can't remember exactly why I did not factor this directly into the RSCoder class, but I think I tried and it led to duplicated code and a performance drop... Anyway, this library is mostly for educational usage, as I think the object-oriented approach is more intuitive to tackle error correction codes. If you want a library for practical use, with good enough (for a pure python) performances and the possibility to use multiple codecs at the same time, you can checkout this library that share the exact same features as unireedsolomon: |
GF2int
is a a global singleton and does not allow multiple RSCoder instances with different field generator polynomials.results in:
The text was updated successfully, but these errors were encountered: