From 2cc5cab0e1f07360bcac50efca11cab11e7c02a7 Mon Sep 17 00:00:00 2001
From: Stefan Niclas Heun <niclas.heun@tum.de>
Date: Thu, 13 Feb 2025 14:03:16 +0100
Subject: [PATCH] changing default sorting behavior

---
 .../ApplicationsAssessment.tsx                | 19 +++++++++++++++++--
 1 file changed, 17 insertions(+), 2 deletions(-)

diff --git a/clients/core/src/managementConsole/applicationAdministration/pages/ApplicationAssessment/ApplicationsAssessment.tsx b/clients/core/src/managementConsole/applicationAdministration/pages/ApplicationAssessment/ApplicationsAssessment.tsx
index ecdf28c5..e386643a 100644
--- a/clients/core/src/managementConsole/applicationAdministration/pages/ApplicationAssessment/ApplicationsAssessment.tsx
+++ b/clients/core/src/managementConsole/applicationAdministration/pages/ApplicationAssessment/ApplicationsAssessment.tsx
@@ -20,7 +20,7 @@ import {
   TableRow,
 } from '@/components/ui/table'
 import { columns } from './components/table/columns'
-import { useState } from 'react'
+import { useEffect, useState } from 'react'
 import { Input } from '@/components/ui/input'
 import { SearchIcon } from 'lucide-react'
 import { FilterMenu } from './components/table/filtering/FilterMenu'
@@ -39,7 +39,10 @@ import { useDeleteApplications } from './hooks/useDeleteApplications'
 
 export const ApplicationsAssessment = (): JSX.Element => {
   const { additionalScores, participations } = useApplicationStore()
-  const [sorting, setSorting] = useState<SortingState>([{ id: 'lastName', desc: false }])
+  const [sorting, setSorting] = useState<SortingState>([
+    { id: 'passStatus', desc: false },
+    { id: 'lastName', desc: false },
+  ])
   const [globalFilter, setGlobalFilter] = useState<string>('')
   const [columnFilters, setColumnFilters] = useState<ColumnFiltersState>([])
   const [columnVisibility, setColumnVisibility] = useState<VisibilityState>({ gender: false })
@@ -92,6 +95,18 @@ export const ApplicationsAssessment = (): JSX.Element => {
     },
   })
 
+  // when sorting for status, this adds sorting by last name
+  useEffect(() => {
+    if (
+      sorting.find((sort) => sort.id === 'passStatus') &&
+      !sorting.find((sort) => sort.id === 'lastName')
+    ) {
+      setSorting((prev) => {
+        return [...prev, { id: 'lastName', desc: false }]
+      })
+    }
+  }, [sorting])
+
   return (
     <div id='table-view' className='relative flex flex-col space-y-6'>
       <ManagementPageHeader>Applications Overview</ManagementPageHeader>