From 3d9acbd1add595b82109b193f9c2028f8703aa4a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lumi=C3=A8re=20=C3=89lev=C3=A9?= <88174309+PoneyClairDeLune@users.noreply.github.com> Date: Tue, 14 Nov 2023 08:34:55 +0000 Subject: [PATCH] Fix a bug in MT-32 timbre write introduced by... the bank fetch revamp. --- src/state/bankReader.js | 6 +++++- src/state/index.mjs | 8 ++++++-- 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/src/state/bankReader.js b/src/state/bankReader.js index 8db2144c..5d716358 100644 --- a/src/state/bankReader.js +++ b/src/state/bankReader.js @@ -584,7 +584,11 @@ let VoiceBank = class { assign.forEach(function (e0, i0) { sig[sgCrit.indexOf(e0)] = i0; }); - console.debug(`Bank map significance: ${sig}`); + //console.debug(`Bank map significance: ${sig}`); + if (sig.length < 4) { + console.debug(`Debugger launched.`); + debugger; + }; } else { let msb = 0, prg = 0, lsb = 0, name, poly = 1, type = 0, drum; assign.forEach(async function (e1, i1) { diff --git a/src/state/index.mjs b/src/state/index.mjs index 9b1c459d..4099bbe1 100644 --- a/src/state/index.mjs +++ b/src/state/index.mjs @@ -1229,7 +1229,9 @@ let OctaviaDevice = class extends CustomEventSource { userBank += String.fromCharCode(e); }; }); - this.userBank.load(`MSB\tLSB\tPRG\n0\t127\t${prg}\t${userBank}`, true); + let loadTsv = `MSB\tLSB\tPRG\tNME\n0\t127\t${prg}\t${userBank}`; + //console.debug(loadTsv); + this.userBank.load(loadTsv, true); bank.name = userBank; bank.ending = " "; }; @@ -3711,7 +3713,9 @@ let OctaviaDevice = class extends CustomEventSource { name = upThis.baseBank.get(0, e + (timbreGroup << 6), 127, "mt32").name; }; upThis.userBank.clearRange({msb: 0, lsb: 127, prg: patch}); - upThis.userBank.load(`MSB\tLSB\tPRG\tNME\n000\t127\t${patch}\t${name}`, true); + let loadTsv = `MSB\tLSB\tPRG\tNME\n000\t127\t${patch}\t${name}`; + //console.debug(loadTsv); + upThis.userBank.load(loadTsv, true); }; }][slot] || (() => {}))(); });