My opinion on such GUI "taste" decisions: If a behavior is a major annoyance (for a significant group of users), then that should be changed to a behavior everyone can live with. If there are groups with conflicting major annoyances, a setting is needed. A good example would probably be the setting for smooth scrolling.

If the current behavior is acceptable, do nothing. It's (1) likely too low priority to be worth the bother and (2) we don't want settings bloat for such minor things.

Is any of the current behavior unacceptable? If so, why?

For me the second point feels more like a bug than an annoyance, having the first result still selected after clearing the search bar sounds wrong to me. Take a file explorer as an example, when you search for something but don't find it you also wouldn't want to still have the first result selected because that's not what you were looking for.

The third point was mentioned in some PR or issue already. I can't tell which opinion prevails here but this might be something where there are major groups for either behavior.

My first point is probably the least important one, personally I'd like to change it to that because I find it utterly annoying to still have the server selected when I really wanted to "get rid of it".

Searching seems broken, noticed by just searching "test".

Current master:

5.10

Interestingly both the master and the 5.10 build change the address etc. to this server and because the current master build tries to match address etc. it also visually selects this server.

Another example:
Current master:

5.10:

In both cases the dev build correctly selected the server that matches the address and description etc. but in my eyes the most intuitive behavior would look something like this:

• the selection is kept - if the selected server is among the search results it will get selected
• if its not then select nothing, the user should select the right server
• clearing the search bar should lead to the selection being set to the "pre-search" selection, joining a server should set the new selection
• marking a server should also set the selection to that server (maybe?)

The current behavior looks wrong to me, selecting a server at the bottom of the list that I can't even join doesn't sound useful to me.

[server selection after] Searching seems broken, noticed by just searching "test".

Can reproduce. The issue is that an incompatible server is considered the "first" result. Ideally the "first" of the compatible servers should be selected but that frankly isn't very useful either.

Should be relatively trivial to address: Just remove the line that intentionally causes this behavior:

This might be fine to address during feature freeze, the current behavior is at least sometimes clearly "buggy".