Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] M28/M29 support on BTT TFF FW #731

Closed
digant73 opened this issue Mar 21, 2022 · 14 comments
Closed

[FEATURE REQUEST] M28/M29 support on BTT TFF FW #731

digant73 opened this issue Mar 21, 2022 · 14 comments

Comments

@digant73
Copy link

Hi

As already anticipated some days ago, M28/M29 are now also supported by the official BTT TFT fw. On it's README.MD I reported a table with all the commands currently supported by TFT fw (see section Printing from Host).
It should be nice if M28/M29 could be now supported by ESP3D fw. Basically it is simply needed to send M28 SD:<file_path> or M28 U:<file_path> to start the write. M29 to stop the write. ESP3D can send all the commands to write on file using checksum (as currently done on onboard SD). Line number and checksum will be simply removed/ignored by TFT fw (because not currently supported).
Furthermore, the writing on onboard SD is now fixed (previously TFT fw was also processing the received commands causing the write failure and a lot of beeps on TFT).

@luc-github
Copy link
Owner

Thank you I will see what need to be done, did you do some evaluation to see what is the transfer speed ?
is that same as current M28/M29 protocol ? which is around 0.4Kb/s

@digant73
Copy link
Author

digant73 commented Mar 22, 2022

I tested it on a ESP-01S and ESP-12S both connected to TFT at 500000b/s with no issue

@luc-github
Copy link
Owner

humm I guess you are mean baud rate

I mean effective data transfer rate=> 1MB file take how long to be transfered?

@digant73
Copy link
Author

digant73 commented Mar 22, 2022

Made some measurements.
A file of 1,106,458 bytes uploaded in 27:30 minutes -> 1,053KB/s of transfer rate.
Same rate for small files (e.g. 120KB -> 0,99KB/s).

@luc-github
Copy link
Owner

Ok so very slow ^_^ faster because not checking the checksum integrity but still slow like hell
The M28/M29 transfer protocol is currently supported in ESP3D 2.1X and webUI 2.1 so I guess it is just a modification of webUI to tell him to allow upload on BTT TFT using the SD: U: filename prefix

I am currently on 3.0 so I need to find time for this

@luc-github
Copy link
Owner

You may be interrested on this #575
MKS protocol allow up to 100KB/s

@digant73
Copy link
Author

digant73 commented Mar 22, 2022

yes, it is needed only to add support to M28 SD:<file_path> (for TFT SD), M28 U:<file_path> (for TFT USB)

@digant73
Copy link
Author

digant73 commented Mar 22, 2022

You may be interrested on this #575 MKS protocol allow up to 100KB/s

interesting. But are you working to add it in the ESP3D fw? TFT seems not involved in that.
I have an MKS WiFi module (ESP12S) connected to a MKS TFT and an ESP01S connected to a BTT TFT.

@luc-github
Copy link
Owner

luc-github commented Mar 22, 2022

Yes this is the plan and as mentioned need to integrate in other FW

adding a daughter library / Serial protocol accross FW (Repetier / Marlin / Smoothieware/ TBD...)

Which include TFT of course

I have discussed with BTT already and one issue is some BTT boards not always connect IO2 pin but only IO0 pin which make mimic of MKS protocol challenging

@digant73
Copy link
Author

digant73 commented Mar 22, 2022

ok. I have a BTT TFT35 V3 and MKS TFT28 V4 eventually just to make some testing.
As far as I see, the MKS Wifi module has IO0 and IO1 while esp01s (on BTT TFT) has IO0 and IO2. Do you know if BTT TFT35 V3 is one of the TFT that could support MKS protocol? is there a lib implementing MKS protocol I could have a look?

@ETE-Design
Copy link

@digant73 Would be very interesting if the BTT TFT35 V3 could be implemented with MKS Protocol :-)

@stale stale bot added the stale label Apr 18, 2022
Repository owner deleted a comment from stale bot Apr 18, 2022
@stale stale bot removed the stale label Apr 18, 2022
Repository owner deleted a comment from stale bot Apr 18, 2022
@stale stale bot added the stale label Jun 12, 2022
Repository owner deleted a comment from stale bot Jun 12, 2022
@stale
Copy link

stale bot commented Jun 12, 2022

This issue has been removed from the stale queue. Please ensure activity to keep it openin the future.

@stale stale bot removed the stale label Jun 12, 2022
@luc-github
Copy link
Owner

ESP3D V3 do not support M28/M29 protocol because too slow and subject to error in real environement, so this implementation won't happen - sorry

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants