-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify deno-lambda version #4
Comments
Should this be config.denoVersion? Is that the way to do this? |
I dont think that is the way. I think that is the legacy way for the 'builds' property - the new 'functions' property does not support config I think. The Node.js runtime uses engines.node in package.json and Go is just pinned to latest 1.x. We can probably pin to latest and let user specify a specific version via the env var DENO_VERSION - that should then 1:1 map to deno-lambda version. That env var can then be specified using |
I'll wait for denoland/deno-lambda#20 to be done before implementing this. |
Mind if I grab this? I was working on delivering a PR for |
Sure. Just be aware I won't merge it until denoland/deno-lambda#20 is closed. |
That's totally fair. I wrote the tests to be compatible with it and I'm giving it a run-through, as well. |
denoland/deno-lambda#20 is closed now: releases will match the deno version. |
@stephengfriend Do you still want to take this? If you don't want to anymore, I'll take it. |
Hey, thanks for checking in. I almost forgot about it. Yes, I'll take a look today. |
Atm now-deno uses the latest release but I think it would be good for users to (optionally?) pass a version number for the deno-lambda release to use.
(In the future this will match the deno version.)
The text was updated successfully, but these errors were encountered: