Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify deno-lambda version #4

Open
hayd opened this issue Feb 3, 2020 · 9 comments
Open

Specify deno-lambda version #4

hayd opened this issue Feb 3, 2020 · 9 comments
Assignees
Labels
feat A new feature good first issue Good for newcomers

Comments

@hayd
Copy link
Contributor

hayd commented Feb 3, 2020

Atm now-deno uses the latest release but I think it would be good for users to (optionally?) pass a version number for the deno-lambda release to use.

(In the future this will match the deno version.)

@lucacasonato lucacasonato self-assigned this Feb 3, 2020
@lucacasonato lucacasonato added feat A new feature good first issue Good for newcomers labels Feb 3, 2020
@lucacasonato lucacasonato removed their assignment Feb 3, 2020
@hayd
Copy link
Contributor Author

hayd commented Feb 3, 2020

Should this be config.denoVersion? Is that the way to do this?

@lucacasonato
Copy link
Owner

I dont think that is the way. I think that is the legacy way for the 'builds' property - the new 'functions' property does not support config I think. The Node.js runtime uses engines.node in package.json and Go is just pinned to latest 1.x. We can probably pin to latest and let user specify a specific version via the env var DENO_VERSION - that should then 1:1 map to deno-lambda version. That env var can then be specified using build.env in now.json.

@lucacasonato
Copy link
Owner

I'll wait for denoland/deno-lambda#20 to be done before implementing this.

@stephengfriend
Copy link
Contributor

Mind if I grab this? I was working on delivering a PR for now dev but noticed it landed a little bit ago.

@lucacasonato
Copy link
Owner

Sure. Just be aware I won't merge it until denoland/deno-lambda#20 is closed.

@stephengfriend
Copy link
Contributor

That's totally fair. I wrote the tests to be compatible with it and I'm giving it a run-through, as well.

@hayd
Copy link
Contributor Author

hayd commented Feb 13, 2020

denoland/deno-lambda#20 is closed now: releases will match the deno version.

@lucacasonato
Copy link
Owner

@stephengfriend Do you still want to take this? If you don't want to anymore, I'll take it.

@stephengfriend
Copy link
Contributor

Hey, thanks for checking in. I almost forgot about it. Yes, I'll take a look today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat A new feature good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants