-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replication of the upscalers #152
Comments
they are also using the BSR degradation used by Rombach et al https://github.com/CompVis/latent-diffusion/tree/e66308c7f2e64cb581c6d27ab6fbeb846828253b/ldm/modules/image_degradation https://github.com/cszn/BSRGAN/blob/main/utils/utils_blindsr.py that I don't have in the repository yet tempted to just go with Imagen's noising procedure (on top of the blur) and call it a day (it would be a lot simpler) |
ok, after adding the BSR image degradation (or some alternative), i think i'm comfortable giving the repository a 1.0 |
@rom1504 yup, no text conditioning needed, i think it should all be in the image embedding! |
Hi all, |
Hey, so we got decent versions of the prior and the basic decoder now.
I think the current code is already able to train upscalers but we need more doc for it.
Let's have a upscaler.md explaining
And then train it!
We can also discuss what's the right dataset, but I figure the laion5B subset we call "laion high resolution" could do the trick (it's 170M images in 1024x1024 or bigger)
I understand only the image (and clip image EMB) is needed and no text ?
The text was updated successfully, but these errors were encountered: