-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All subsequent tests will be skipped if throw non Error #229
Comments
The problem is even more serious than I expected. All subsequent tests will be silently skipped. Even if the test itself worries about this problematic behavior, any third-party library that is used in the code can cause trouble and completely disable testing. test('example', () => {
externalLibFail()
})
test('example2', () => {
throw new Error("It will never be called")
})
function externalLibFail() {
throw "not an Error"
} |
I have opened a PR to fix this issue. |
When are you going to merge it? I want this fix too. Thanks! |
Just encountered this behavior after few years of using I've looked through other issues and found out, that author knew about this behavior since 2021, but did nothing (not even changed documentation) — #130 (comment) |
Thanks for the nice lib! Just started using it and found a bug:
As result test fail will be silently ignored. The bug is here:
format
function expects that err is defined and isError
instance although this is not required.The text was updated successfully, but these errors were encountered: