Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

html formatting #2

Open
hatemhosny opened this issue Dec 6, 2020 · 1 comment · May be fixed by #3
Open

html formatting #2

hatemhosny opened this issue Dec 6, 2020 · 1 comment · May be fixed by #3

Comments

@hatemhosny
Copy link

great project!
Thank you for open sourcing it.

I noticed that html formatting has some issues

example on monacode.live

on ⌘ + s, the html is formatted correctly but a semi-colon is added to the end

another example with spaces

you get {" "}

I think this is related to babel parser

any guidance?

@lukejacksonn
Copy link
Owner

Ahh yes, good spot! I think this is because prettier is thinking that this is TS/JSX. Probably that is the default and you have to pass it a language prop to make it think otherwise.

I guess we could configure it either by a key in the config and url (preferred), or by adding some UI (probably less preferred but it might work out ok).

@hatemhosny hatemhosny linked a pull request Dec 8, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants