Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

several issues while test-driving PTerm #3

Open
4 of 5 tasks
eMBee opened this issue Oct 24, 2018 · 7 comments
Open
4 of 5 tasks

several issues while test-driving PTerm #3

eMBee opened this issue Oct 24, 2018 · 7 comments

Comments

@eMBee
Copy link

eMBee commented Oct 24, 2018

it's exciting to see a working terminal in pharo.
it seems to work well enough for daily use.

i did notice a few issues however. for simplicity i am going to list them all here, and break them out into individual bug reports later depending on what makes sense.

  • unicode doesn't seem to work.
  • a few terminal escape sequences are not recognized. (this issue went away after unicode was fixed)
  • colors are to bright. (eg. yellow on white is unreadable)
  • some keys don't work (most likely because pharo treats them differently. like pgup,pgdown, backspace also has issues in some applications.)
  • copy-paste seems to work, but could maybe be described in a help screen, or in the first view of the terminal.

from these, unicode is the most pressing because it messes up the display and makes some things unreadable. escape sequences are needed for the fish shell.

i don't know how much i can help, but i can at least provide more details where needed and test.

if unicode can be fixed then i can use this terminal permanently without having a backup terminal around.

i use tmux, so i can switch between terminals easily. helps a lot for testing while doing my actual work

@lxsang
Copy link
Owner

lxsang commented Oct 24, 2018

I will try to deal with the unicode problem first, can you provide with more detail on how to reproduce the problem? , probably a specific use case example that uses unicode.
Thanks

@lxsang
Copy link
Owner

lxsang commented Oct 31, 2018

Hello again,

Unicode should work by now (except Thai, Chinese, Japanese... which are not correctly display, this is something related to Pharo).

Note that, to display unicode, PTerm uses "DejaVu Sans mono" "GNU Unifont" font for better unicode support (it dont look really nice though), you should have this font installed on your system, PTerm automatically download them if needed.
Please give feedback if you still have problems with unicode

@lxsang
Copy link
Owner

lxsang commented Oct 31, 2018

Dark mode is now enabled by default in PTerm

Cheers

@lxsang
Copy link
Owner

lxsang commented Oct 31, 2018

For the others problems, I need more detail on how to reproduce them.

Thx

@eMBee
Copy link
Author

eMBee commented Nov 2, 2018

hey, thank you. i don't have much time to focus on this, so my responses will always be sporadic with a delay. i do hope to get back into more smalltalk coding again, so i'll see what i can do in the future.

i'll open separate issues for anything specific, so for now, just some comments:

  • unicode support does look better, but apparently i can't get the right font loaded. (unifont fails to load and fallback is the default font which is not monospace #4)
  • the color issue is not solved by changing to dark. that's tangential. the problem is that the colors are not balanced. yellow on white is unreadable and white and bright white are indistinguishable. in dark mode both are the same dark green. i'll create an issue with screenshots later.

@lxsang
Copy link
Owner

lxsang commented Nov 9, 2018

Color problem is fixed with the new added themes

@eMBee
Copy link
Author

eMBee commented Nov 10, 2018

nice.
at this point, ctrl-w is the only remaining case where i need to switch to a backup terminal. it happens rarely enough to not be any problem though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants