From 5e804990cd749e18e507d38838395233eab55124 Mon Sep 17 00:00:00 2001 From: anandswaminathan Date: Tue, 15 Nov 2022 13:58:38 -0800 Subject: [PATCH] Migrate to networking.k8s.io v1 --- pkg/controller/flink/ingress.go | 20 +++++++++---------- .../flink/job_manager_controller_test.go | 8 ++++---- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/pkg/controller/flink/ingress.go b/pkg/controller/flink/ingress.go index bbb67b3f..cce18069 100644 --- a/pkg/controller/flink/ingress.go +++ b/pkg/controller/flink/ingress.go @@ -8,7 +8,7 @@ import ( "github.com/lyft/flinkk8soperator/pkg/controller/common" "github.com/lyft/flinkk8soperator/pkg/controller/config" "github.com/lyft/flinkk8soperator/pkg/controller/k8" - "k8s.io/api/networking/v1beta1" + v1network "k8s.io/api/networking/v1" v1 "k8s.io/apimachinery/pkg/apis/meta/v1" "k8s.io/apimachinery/pkg/util/intstr" ) @@ -25,7 +25,7 @@ func GetFlinkUIIngressURL(jobName string) string { return ReplaceJobURL(config.GetConfig().FlinkIngressURLFormat, jobName) } -func FetchJobManagerIngressCreateObj(app *flinkapp.FlinkApplication) *v1beta1.Ingress { +func FetchJobManagerIngressCreateObj(app *flinkapp.FlinkApplication) *v1network.Ingress { podLabels := common.DuplicateMap(app.Labels) podLabels = common.CopyMap(podLabels, k8.GetAppLabel(app.Name)) @@ -38,7 +38,7 @@ func FetchJobManagerIngressCreateObj(app *flinkapp.FlinkApplication) *v1beta1.In }, } - backend := v1beta1.IngressBackend{ + backend := v1network.IngressBackend{ ServiceName: getJobManagerServiceName(app), ServicePort: intstr.IntOrString{ Type: intstr.Int, @@ -46,22 +46,22 @@ func FetchJobManagerIngressCreateObj(app *flinkapp.FlinkApplication) *v1beta1.In }, } - ingressSpec := v1beta1.IngressSpec{ - Rules: []v1beta1.IngressRule{{ + ingressSpec := v1network.IngressSpec{ + Rules: []v1network.IngressRule{{ Host: GetFlinkUIIngressURL(getIngressName(app)), - IngressRuleValue: v1beta1.IngressRuleValue{ - HTTP: &v1beta1.HTTPIngressRuleValue{ - Paths: []v1beta1.HTTPIngressPath{{ + IngressRuleValue: v1network.IngressRuleValue{ + HTTP: &v1network.HTTPIngressRuleValue{ + Paths: []v1network.HTTPIngressPath{{ Backend: backend, }}, }, }, }}, } - return &v1beta1.Ingress{ + return &v1network.Ingress{ ObjectMeta: ingressMeta, TypeMeta: v1.TypeMeta{ - APIVersion: v1beta1.SchemeGroupVersion.String(), + APIVersion: v1network.SchemeGroupVersion.String(), Kind: k8.Ingress, }, Spec: ingressSpec, diff --git a/pkg/controller/flink/job_manager_controller_test.go b/pkg/controller/flink/job_manager_controller_test.go index 5d3361fa..f96b1daa 100644 --- a/pkg/controller/flink/job_manager_controller_test.go +++ b/pkg/controller/flink/job_manager_controller_test.go @@ -20,7 +20,7 @@ import ( "github.com/stretchr/testify/assert" v1 "k8s.io/api/apps/v1" coreV1 "k8s.io/api/core/v1" - "k8s.io/api/networking/v1beta1" + v1network "k8s.io/api/networking/v1" k8sErrors "k8s.io/apimachinery/pkg/api/errors" "k8s.io/apimachinery/pkg/runtime" "k8s.io/apimachinery/pkg/runtime/schema" @@ -132,7 +132,7 @@ func TestJobManagerCreateSuccess(t *testing.T) { labels := map[string]string{ "flink-app": "app-name", } - ingress := object.(*v1beta1.Ingress) + ingress := object.(*v1network.Ingress) assert.Equal(t, app.Name, ingress.Name) assert.Equal(t, app.Namespace, ingress.Namespace) assert.Equal(t, labels, ingress.Labels) @@ -215,7 +215,7 @@ func TestJobManagerHACreateSuccess(t *testing.T) { labels := map[string]string{ "flink-app": "app-name", } - ingress := object.(*v1beta1.Ingress) + ingress := object.(*v1network.Ingress) assert.Equal(t, app.Name, ingress.Name) assert.Equal(t, app.Namespace, ingress.Namespace) assert.Equal(t, labels, ingress.Labels) @@ -430,7 +430,7 @@ func TestJobManagerCreateSuccessWithVersion(t *testing.T) { labels := map[string]string{ "flink-app": "app-name", } - ingress := object.(*v1beta1.Ingress) + ingress := object.(*v1network.Ingress) assert.Equal(t, app.Name+"-"+testVersion, ingress.Name) assert.Equal(t, app.Namespace, ingress.Namespace) assert.Equal(t, labels, ingress.Labels)