Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Add zlib-ng as a zlib replacement #2812

Open
woot000 opened this issue Dec 27, 2024 · 2 comments
Open

Request: Add zlib-ng as a zlib replacement #2812

woot000 opened this issue Dec 27, 2024 · 2 comments

Comments

@woot000
Copy link
Contributor

woot000 commented Dec 27, 2024

Would be nice to replace zlib with zlib-ng for the performance uplift, since a lot of libraries in the suite use zlib. I'm submitting an issue instead of a pull request because I'm waiting for zlib-ng to be added as an MSYS2 package before I try adding it.

@gitoss
Copy link

gitoss commented Dec 29, 2024

Specifically, it would be zlib-ng-compat as a drop-in replacement, correct?

For an optimized approach like mabs, it might not be necressary to wait for the MSYS2 package but to build mabs' own zlib-ng into local - WITH_RUNTIME_CPU_DETECTION could be disabled because it's for a specific system anyway. https://github.com/zlib-ng/zlib-ng/blob/develop/CMakeLists.txt

@L4cache
Copy link
Contributor

L4cache commented Jan 1, 2025

Specifically, it would be zlib-ng-compat as a drop-in replacement, correct?

For an optimized approach like mabs, it might not be necressary to wait for the MSYS2 package but to build mabs' own zlib-ng into local - WITH_RUNTIME_CPU_DETECTION could be disabled because it's for a specific system anyway. https://github.com/zlib-ng/zlib-ng/blob/develop/CMakeLists.txt

No, runtime cpu detection is as the name suggests, detect cpu (available instruction sets) at runtime, it's not for a specific system, disabling it will make it "system specific".
I'm talking about the general idea of runtime cpu detection, not sure if zlib-ng actually made it the other way around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants