Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass custom environment variables to rooms #130

Open
Dalethium opened this issue Jul 30, 2024 · 6 comments
Open

Pass custom environment variables to rooms #130

Dalethium opened this issue Jul 30, 2024 · 6 comments
Labels
enhancement New feature or request

Comments

@Dalethium
Copy link

Looking into the source code for this program, I don't see a place to specify environment variables such as the ones below.

NEKO_ICELITE: 'false'
NEKO_ICESERVERS: '[{ "urls": [ "turn:10.0.0.1:3478" ], "username":"neko", "credential":"neko" }, { "urls": [ "stun:stun.nextcloud.com:3478" ] }]'

Is there any way we could get the ability to pass custom environment variables to each of the containers spawned by this?

@m1k1o
Copy link
Owner

m1k1o commented Jul 30, 2024

Hello. When creating room you can specify environment variables. Some of them are added automatically by the system, do you need to rewrite them?

@Dalethium
Copy link
Author

I was hoping to have some added by default, more specifically.

@m1k1o
Copy link
Owner

m1k1o commented Jul 31, 2024

Do you mean by default to all rooms when specifying in docker compose? Currently only available per room. But there is openapi spec and you can just create your own gui wrapper that sets those env variables for every room that you need.

@Dalethium
Copy link
Author

Yeah, that's exactly what I mean. Do you plan on implementing something like that, or is it just outside the scope of what you want to do?

@m1k1o
Copy link
Owner

m1k1o commented Aug 1, 2024

We cannot just pass all env variabled because then would be also configuration of neko rooms passed to each room. And we also cannot pass all NEKO_ env varibles because then again NEKO_ROOMS_ would be passed.

Maybe all NEKO_ that do not start with NEKO_ROOMS_ if that would not be very confusing.

@Dalethium
Copy link
Author

That seems like a great solution, to be honest!

Or just something that is more specifically like NEKO_GLOBAL_ if that's easier.

@m1k1o m1k1o added the enhancement New feature or request label Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants