Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Return container stats with the stats response #87

Open
gbrian opened this issue Feb 18, 2023 · 3 comments
Open

[Improvement] Return container stats with the stats response #87

gbrian opened this issue Feb 18, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@gbrian
Copy link
Contributor

gbrian commented Feb 18, 2023

Hi, planning to return container stats with the "stats" request.
What about using https://github.com/KyleBanks/dockerstats ? Do you know better way?
Thanks

@gbrian
Copy link
Contributor Author

gbrian commented Feb 18, 2023

@m1k1o
Copy link
Owner

m1k1o commented Feb 18, 2023

Neko itself is not aware aobut the container that is living in. So i would prefer to keep it separate, and have stats about neko itself in neko and status about the container from neko-roooms, since neko rooms has access to the docker socket and can get easily stats from it.

dockerstats looks interesting, but seems like is not maintained. They also call docker CLI and parse data from it. We can get all those information directly from docker socket in a much nicer way.

@m1k1o m1k1o added the enhancement New feature or request label Apr 8, 2023
@m1k1o
Copy link
Owner

m1k1o commented Nov 4, 2023

Basically just parsing docker stats --no-stream --format json <container> respone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants