Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spectrally accurate 1D indefinite integration #298

Open
mrhardman opened this issue Dec 12, 2024 · 2 comments · May be fixed by #299
Open

Spectrally accurate 1D indefinite integration #298

mrhardman opened this issue Dec 12, 2024 · 2 comments · May be fixed by #299
Labels
discussion

Comments

@mrhardman
Copy link
Collaborator

A note to record that the present calculation of phi from Epar for the kinetic and fluid electron options

moment_kinetics/moment_kinetics/src/em_fields.jl

Line 177 in eac094f

function calculate_phi_from_Epar!(phi, Epar, r, z)
uses a (presumably secord-order accurate) trapezoidal rule. It is possible to formulate a 1D indefinite integral using the same spectral methods as used to form the differentiation matrices in moment_kinetics, with the caveat that there is a free integration constant to be accounted for. If the accuracy of the 1D indefinite integration method is a limiting factor in the calculation for any user/developer, please comment here and I will implement the spectrally accurate indefinite integration method.
@mrhardman
Copy link
Collaborator Author

I have made an initial start on a spectrally accurate 1D line integration feature here https://github.com/mabarnes/moment_kinetics/tree/line-integration.

@mrhardman
Copy link
Collaborator Author

Now addressed in #299

@mrhardman mrhardman linked a pull request Jan 2, 2025 that will close this issue
Line integration #299
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Line integration mabarnes/moment_kinetics
1 participant
@mrhardman