You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Better not to mix the UI implementation detail (whether the shift key being held down) with the internal state logic (whether to set focus time or focus interval).
I think we'd be better served here by having a separate reducer action to set the interval (and maybe it takes both ends of the interval, or is overloaded so that it infers that one of them is the current focus time if it only gets one time) and let the front-end look at the shift key to choose which to call. (This would also make it easier to implement a drag-based version if we changed our minds or wanted to make it easier for the user to modify an existing interval.)
Better not to mix the UI implementation detail (whether the shift key being held down) with the internal state logic (whether to set focus time or focus interval).
I think we'd be better served here by having a separate reducer action to set the interval (and maybe it takes both ends of the interval, or is overloaded so that it infers that one of them is the current focus time if it only gets one time) and let the front-end look at the shift key to choose which to call. (This would also make it easier to implement a drag-based version if we changed our minds or wanted to make it easier for the user to modify an existing interval.)
Originally posted by @jsoules in #140 (comment)
The text was updated successfully, but these errors were encountered: