Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS error - success is not defined #19

Open
Sicria opened this issue Aug 26, 2016 · 1 comment
Open

JS error - success is not defined #19

Sicria opened this issue Aug 26, 2016 · 1 comment

Comments

@Sicria
Copy link

Sicria commented Aug 26, 2016

A JS error is thrown when the timeout occurs because of an undefined variable here.
https://github.com/mailgun/validator-demo/blob/master/mailgun_validator.js#L100

This was introduced here d0012f4#diff-2058a81314d1963d903b2bfdf54a9773L75
@msigley
Copy link
Contributor

msigley commented Sep 19, 2016

My latest version of this already had this bug fixed last November. I'll submit a PR to fix this.

@msigley msigley mentioned this issue Sep 19, 2016
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Sicria @msigley