From 4b3af4f55e4faf1c34172a6d0ba31e841f35dee6 Mon Sep 17 00:00:00 2001 From: Mihail Akimenko Date: Thu, 7 Dec 2023 22:03:56 +0200 Subject: [PATCH] fix: linting --- .../lib/animation/timeline-emitter/emit-step.component.ts | 2 +- .../animation/timeline-emitter/timeline-emitter.component.ts | 2 +- .../atft/src/lib/object/loader/audio-loader.component.ts | 4 ++-- src/stories/basic/timeline/timeline-emitter.stories.ts | 5 ++--- 4 files changed, 6 insertions(+), 7 deletions(-) diff --git a/projects/atft/src/lib/animation/timeline-emitter/emit-step.component.ts b/projects/atft/src/lib/animation/timeline-emitter/emit-step.component.ts index f64eda5a..a9608e00 100644 --- a/projects/atft/src/lib/animation/timeline-emitter/emit-step.component.ts +++ b/projects/atft/src/lib/animation/timeline-emitter/emit-step.component.ts @@ -34,7 +34,7 @@ export class EmitStepComponent implements AfterViewInit, OnDestroy, OnChanges { } public ngOnChanges(changes: SimpleChanges) { - console.log('EmitStepComponent.ngOnChanges'); + console.log('EmitStepComponent.ngOnChanges', changes); } } diff --git a/projects/atft/src/lib/animation/timeline-emitter/timeline-emitter.component.ts b/projects/atft/src/lib/animation/timeline-emitter/timeline-emitter.component.ts index f4abffed..78b52000 100644 --- a/projects/atft/src/lib/animation/timeline-emitter/timeline-emitter.component.ts +++ b/projects/atft/src/lib/animation/timeline-emitter/timeline-emitter.component.ts @@ -36,7 +36,7 @@ export class TimelineEmitterComponent implements AfterViewInit, OnDestroy, OnCha } public ngOnChanges(changes: SimpleChanges) { - console.log('TimelineEmitterComponent.ngOnChanges'); + console.log('TimelineEmitterComponent.ngOnChanges', changes); } ngOnInit(): void { diff --git a/projects/atft/src/lib/object/loader/audio-loader.component.ts b/projects/atft/src/lib/object/loader/audio-loader.component.ts index 41e108a9..c2656e7f 100644 --- a/projects/atft/src/lib/object/loader/audio-loader.component.ts +++ b/projects/atft/src/lib/object/loader/audio-loader.component.ts @@ -1,4 +1,4 @@ -import {Component, EventEmitter, Input, Optional, Output, SkipSelf} from '@angular/core'; +import {Component, EventEmitter, Input, OnDestroy, Optional, Output, SkipSelf} from '@angular/core'; import * as THREE from 'three'; import {RendererService} from '../../renderer/renderer.service'; @@ -11,7 +11,7 @@ import {AbstractModelLoader} from './abstract-model-loader'; providers: [provideParent(AudioLoaderComponent)], template: '' }) -export class AudioLoaderComponent extends AbstractModelLoader { +export class AudioLoaderComponent extends AbstractModelLoader implements OnDestroy { private loader = new THREE.AudioLoader(); private listener = new THREE.AudioListener(); private sound = new THREE.Audio(this.listener); diff --git a/src/stories/basic/timeline/timeline-emitter.stories.ts b/src/stories/basic/timeline/timeline-emitter.stories.ts index 8ea22538..819bbe76 100644 --- a/src/stories/basic/timeline/timeline-emitter.stories.ts +++ b/src/stories/basic/timeline/timeline-emitter.stories.ts @@ -2,7 +2,6 @@ import {Component, Input} from '@angular/core'; import {Meta, moduleMetadata, StoryObj} from '@storybook/angular'; // NOTE: Do direct import instead of library (allows to watch component and easy to develop) import {AtftModule} from '../../../../projects/atft/src/lib/atft.module'; -import {worldSceneWrapper} from "../../scene-wrapper/world-scene-wrapper"; import {axesSceneWrapper} from "../../scene-wrapper/axes-scene-wrapper"; @@ -19,8 +18,8 @@ import {axesSceneWrapper} from "../../scene-wrapper/axes-scene-wrapper"; `) }) class TimelineEmitterStoryComponent { - visibleOne = false; - visibleTwo = false; + @Input() visibleOne = false; + @Input() visibleTwo = false; }