Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable nightly standalone packages to install mslice nightly versions #38674

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

thomashampson
Copy link
Contributor

@thomashampson thomashampson commented Jan 22, 2025

Description of work

The standalone installer scripts install mantidworkbench into a conda environment before bundling up all the files into an installable package. Recently, the mantid anaconda channel was added as a source to facilitate the installation of mslice as a conda package via the dependencies of mantidworkbench. Here the channel mantid/label/nightly is also added so that nightly versions of the standalone pacakages are able to install nightly versions of mslice that are not on the main label. The nightly label is only added when the package suffix is either Nightly or Unstable, which means release versions of the standalone packages will only pick up the released versions of mslice.

Fixes #38628

To test:

On each OS:

  1. Download and install the standalone package from this build
  2. Open the application
  3. Enter the following in the Python console, it should return '2.10.1.dev25+uncommitted':
import mslice
mslice.__version__

This does not require release notes because this is attempting to reproduce the old behaviour when we used the SHA to keep mslice up to date


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@thomashampson thomashampson added the Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) label Jan 22, 2025
@sf1919 sf1919 added this to the Release 6.12 milestone Jan 23, 2025
@sf1919 sf1919 linked an issue Jan 23, 2025 that may be closed by this pull request
@thomashampson thomashampson force-pushed the 38628_fix_mslice_nightly_version_bug branch from 69791f1 to 35b79cf Compare January 23, 2025 11:28
@thomashampson thomashampson marked this pull request as ready for review January 23, 2025 15:54
@jhaigh0
Copy link
Contributor

jhaigh0 commented Jan 23, 2025

I can confirm this works on Windows

@thomashampson thomashampson force-pushed the 38628_fix_mslice_nightly_version_bug branch 2 times, most recently from 9da8f58 to 46b2dcf Compare January 24, 2025 12:42
@thomashampson thomashampson marked this pull request as draft January 24, 2025 12:43
@thomashampson thomashampson force-pushed the 38628_fix_mslice_nightly_version_bug branch from 46b2dcf to c98c597 Compare January 24, 2025 16:01
@jclarkeSTFC jclarkeSTFC marked this pull request as ready for review January 27, 2025 09:23
@jclarkeSTFC jclarkeSTFC self-assigned this Jan 27, 2025
Copy link
Contributor

@jclarkeSTFC jclarkeSTFC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Standalone installers worked correctly on Windows, macOS, and IDAaaS.

@jclarkeSTFC jclarkeSTFC requested a review from jhaigh0 January 27, 2025 09:24
@SilkeSchomann SilkeSchomann self-assigned this Jan 27, 2025
@SilkeSchomann SilkeSchomann merged commit 15d8d2e into release-next Jan 27, 2025
10 checks passed
@SilkeSchomann SilkeSchomann deleted the 38628_fix_mslice_nightly_version_bug branch January 27, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure released Mantid version uses a specific released MSlice version
5 participants