Enable nightly standalone packages to install mslice nightly versions #38674
+27
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
The standalone installer scripts install
mantidworkbench
into a conda environment before bundling up all the files into an installable package. Recently, themantid
anaconda channel was added as a source to facilitate the installation ofmslice
as a conda package via the dependencies ofmantidworkbench
. Here the channelmantid/label/nightly
is also added so that nightly versions of the standalone pacakages are able to install nightly versions ofmslice
that are not on themain
label. Thenightly
label is only added when the package suffix is eitherNightly
orUnstable
, which means release versions of the standalone packages will only pick up the released versions ofmslice
.Fixes #38628
To test:
On each OS:
'2.10.1.dev25+uncommitted'
:This does not require release notes because this is attempting to reproduce the old behaviour when we used the SHA to keep mslice up to date
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeepers
will take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.