Manual Testing Engineering Diffraction

[warunawickramasingha]

You have been assigned manual testing. The hope is to catch as many problems with the code before release, so it would be great if you can take some time to give a serious test to your assigned area. Thank you!!

The general guide to manual testing:

• The tests must be performed on the installer versions of the final release candidate. Not on local compiled code.
• Serious errors involving loss of functionality, crashes etc. should be raised
  as issues with the current release as a milestone and an email sent to the project manager immediately.
• Minor and cosmetic issues should be raised as issues against the forthcoming
  releases.
• First try things that should work, then try to break Mantid, e.g. entering invalid values, unexpected characters etc.
• Don't spend more than a few hours on the testing as fatigue will kick in.
• If you find errors in the documentation, please correct them.
• Comment against this ticket the OS environment you are testing against.
• Disable Usage reporting before you start testing
• Close the this issue once you are done.
• Time how long this manual test takes for you to do and leave a comment about it in this issue.

Specific Notes:

https://developer.mantidproject.org/Testing/EngineeringDiffraction/EngineeringDiffractionTestGuide.html

[robertapplin]

Attempting to Load ENGINX 305738 into Mantid, it seems not to be able to find the file in the data archive (on Windows)

[robertapplin]

We discussed it might be useful to put the files for this test into the UsageData or somewhere else, because it took hours to find and download them for everyone

ENGINX 305738, 305793-95, 307521, 305761

[cailafinn]

NOT A REGRESSION

(Slightly unreliable) Crash when deleting workspaces that have been loaded into the fitting tab:

1. Load a number of focused files into the Fitting ta with Add to plot ticked.
2. Select a chunk (half or more) workspaces in the ADS and click delete.
3. This error should appear:

Error occurred in handler:
Traceback (most recent call last):
  File "/Applications/MantidWorkbenchNightly.app/Contents/Resources/lib/python3.10/site-packages/mantidqtinterfaces/Engineering/gui/engineering_diffraction/tabs/common/data_handling/data_presenter.py", line 190, in _handle_table_cell_changed
    ws = self.model.get_active_ws(loaded_ws_name)
  File "/Applications/MantidWorkbenchNightly.app/Contents/Resources/lib/python3.10/site-packages/mantidqtinterfaces/Engineering/gui/engineering_diffraction/tabs/common/data_handling/data_model.py", line 90, in get_active_ws
    return self._data_workspaces[loaded_ws_name].get_active_ws()
  File "/Applications/MantidWorkbenchNightly.app/Contents/Resources/lib/python3.10/site-packages/mantidqtinterfaces/Engineering/gui/engineering_diffraction/tabs/common/workspace_record.py", line 46, in __getitem__
    return self.dict[key]
KeyError: 'ENGINX_305794_307521_bank_2_TOF_Fitting'

[warunawickramasingha]

NOT A regression

It's the same issue as mentioned above, screenshot from IDAaaS

[cailafinn]

BG column mentioned here is not present on the runs table. Test instructions need updating.

[warunawickramasingha]

NOT a regression

While following Test 11 on IDAaaS, at step 8 after changing max limit to 15000 getting an error like shown

EngineeringDiffractionTestGuide.html#id15)
GSAS-II call failed with error: /opt/gsas2/GSASII/GSASIIstrMath.py:4104: RuntimeWarning: invalid value encountered in double_scalars
  Histogram['Residuals']['Rb'] = min(100.,100.*sumYB/sumYmB)
/opt/gsas2/GSASII/GSASIIstrMath.py:4105: RuntimeWarning: invalid value encountered in double_scalars
  Histogram['Residuals']['wRb'] = min(100.,100.*ma.sqrt(sumwYB2/sumwYmB2))
Traceback (most recent call last):
  File "/opt/mantidworkbenchnightly/lib/python3.10/site-packages/mantidqtinterfaces/Engineering/gui/engineering_diffraction/tabs/gsas2/call_G2sc.py", line 232, in <module>
    main()
  File "/opt/mantidworkbenchnightly/lib/python3.10/site-packages/mantidqtinterfaces/Engineering/gui/engineering_diffraction/tabs/gsas2/call_G2sc.py", line 218, in main
    print_histogram_R_factors(gsas_project)
  File "/opt/mantidworkbenchnightly/lib/python3.10/site-packages/mantidqtinterfaces/Engineering/gui/engineering_diffraction/tabs/gsas2/call_G2sc.py", line 17, in print_histogram_R_factors
    print("\t{:20s}: {:.2f}".format(loop_histogram.name, loop_histogram.get_wR()))
TypeError: unsupported format string passed to NoneType.__format__

For the same limits when Refine in GSAS2 is called with Refinement set to Rietveld it made a crash like below

#38668 was raised for this.

[warunawickramasingha]

NOT A REGRESSION

(Slightly unreliable) Crash when deleting workspaces that have been loaded into the fitting tab:

1. Load a number of focused files into the Fitting ta with Add to plot ticked.
2. Select a chunk (half or more) workspaces in the ADS and click delete.
3. This error should appear:

Error occurred in handler:
Traceback (most recent call last):
  File "/Applications/MantidWorkbenchNightly.app/Contents/Resources/lib/python3.10/site-packages/mantidqtinterfaces/Engineering/gui/engineering_diffraction/tabs/common/data_handling/data_presenter.py", line 190, in _handle_table_cell_changed
    ws = self.model.get_active_ws(loaded_ws_name)
  File "/Applications/MantidWorkbenchNightly.app/Contents/Resources/lib/python3.10/site-packages/mantidqtinterfaces/Engineering/gui/engineering_diffraction/tabs/common/data_handling/data_model.py", line 90, in get_active_ws
    return self._data_workspaces[loaded_ws_name].get_active_ws()
  File "/Applications/MantidWorkbenchNightly.app/Contents/Resources/lib/python3.10/site-packages/mantidqtinterfaces/Engineering/gui/engineering_diffraction/tabs/common/workspace_record.py", line 46, in __getitem__
    return self.dict[key]
KeyError: 'ENGINX_305794_307521_bank_2_TOF_Fitting'

#38667 is raised for this

[cailafinn]

We discussed it might be useful to put the files for this test into the UsageData or somewhere else, because it took hours to find and download them for everyone

ENGINX 305738, 305793-95, 307521, 305761

Issue created for this:

• All Manual Testing Data Available as Download #38662

[cailafinn]

All issues found have issues created. No regressions.