Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual Testing M-slice #38642

Closed
warunawickramasingha opened this issue Jan 21, 2025 · 10 comments
Closed

Manual Testing M-slice #38642

warunawickramasingha opened this issue Jan 21, 2025 · 10 comments
Assignees
Labels
Manual Tests Only for issues that are unscripted testing tasks during the release period
Milestone

Comments

@warunawickramasingha
Copy link
Contributor

You have been assigned manual testing. The hope is to catch as many problems with the code before release, so it would be great if you can take some time to give a serious test to your assigned area. Thank you!!

The general guide to manual testing:

  • The tests must be performed on the installer versions of the final release candidate. Not on local compiled code.
  • Serious errors involving loss of functionality, crashes etc. should be raised
    as issues with the current release as a milestone and an email sent to the project manager immediately.
  • Minor and cosmetic issues should be raised as issues against the forthcoming
    releases.
  • First try things that should work, then try to break Mantid, e.g. entering invalid values, unexpected characters etc.
  • Don't spend more than a few hours on the testing as fatigue will kick in.
  • If you find errors in the documentation, please correct them.
  • Comment against this ticket the OS environment you are testing against.
  • Disable Usage reporting before you start testing
  • Close the this issue once you are done.
  • Time how long this manual test takes for you to do and leave a comment about it in this issue.

Specific Notes:

https://developer.mantidproject.org/Testing/Direct/MSliceTestGuide.html

@warunawickramasingha warunawickramasingha added the Manual Tests Only for issues that are unscripted testing tasks during the release period label Jan 21, 2025
@warunawickramasingha warunawickramasingha added this to the Release 6.12 milestone Jan 21, 2025
@cailafinn
Copy link
Contributor

@SilkeSchomann We're having some issues with M-Slice versions on Windows & macOS.

Windows and macOS (Both Standalone): 2.10.1+uncommitted (nightly & main label)
Linux (Conda & Standalone): 2.10.1.dev25+uncommitted (nightly label)

Windows and macOS seem to be targeting the main label, rather than the nightly.

@sf1919
Copy link
Contributor

sf1919 commented Jan 21, 2025

There is an issue already open for this so any details you can add to #38628 would be welcome

@SilkeSchomann
Copy link
Contributor

@SilkeSchomann We're having some issues with M-Slice versions on Windows & macOS.

Windows and macOS (Both Standalone): 2.10.1+uncommitted (nightly & main label) Linux (Conda & Standalone): 2.10.1.dev25+uncommitted (nightly label)

Windows and macOS seem to be targeting the main label, rather than the nightly.

For a Conda installation, you could just install the MSlice nightly in your Conda environment. For non-Conda installations the only option is to search for the mslice folder for your installation and replace it with https://github.com/mantidproject/mslice/tree/main/src/mslice

@thomashampson
Copy link
Contributor

There was a mistake in the earlier report: it looks like standalone packages on all OS have the same version of mslice, and the conda installs on all OS have the latest nightly one. I have a full understanding of why and have commented on the issue.

@cailafinn
Copy link
Contributor

cailafinn commented Jan 22, 2025

NOT A REGRESSION. PRESENT IN 6.11

This dropdown to the right of Compose is crushed on macOS:

Image

@robertapplin
Copy link
Contributor

robertapplin commented Jan 22, 2025

The output plot looks slightly different for this test https://developer.mantidproject.org/Testing/Direct/MSliceTestGuide.html#changing-the-intensity-of-a-cut

The data has no margin at the low y and high y:

Image

@cailafinn
Copy link
Contributor

cailafinn commented Jan 22, 2025

NOT A REGRESSION. PRESENT IN 6.11

UnEx on Plot Over step:

Image

  1. Create a plot.
  2. Change to Chi''(Q,E)
  3. Display a bragg peak (aluminium)
  4. Plot Over

@warunawickramasingha
Copy link
Contributor Author

warunawickramasingha commented Jan 22, 2025

4. Interactive Cuts step 9, the instructions need to be updated, since it is the x axis label that is changing when Click on Flip Integration Axis.

@robertapplin
Copy link
Contributor

robertapplin commented Jan 22, 2025

I get unreliable crashes when following the last test with the ADS. If you mess around with it for long enough then a crash like this will happen:

Image

Traceback (most recent call last):
  File "/home/mlc47243/mambaforge/envs/mantid_env/lib/python3.10/site-packages/mslice/models/workspacemanager/workspace_provider.py", line 12, in get_workspace_handle
    return _loaded_workspaces[workspace_name]
KeyError: 'MAR21335_Ei60meV_cut(22.124,38.583)_(1)'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/mlc47243/mambaforge/envs/mantid_env/lib/python3.10/site-packages/mslice/widgets/workspacemanager/workspacemanager.py", line 198, in list_item_changed
    self._presenter.notify(Command.SelectionChanged)
  File "/home/mlc47243/mambaforge/envs/mantid_env/lib/python3.10/site-packages/mslice/presenters/workspace_manager_presenter.py", line 52, in notify
    self._command_map[command]()
  File "/home/mlc47243/mambaforge/envs/mantid_env/lib/python3.10/site-packages/mslice/presenters/workspace_manager_presenter.py", line 58, in _broadcast_selected_workspaces
    self._get_main_presenter().notify_workspace_selection_changed()
  File "/home/mlc47243/mambaforge/envs/mantid_env/lib/python3.10/site-packages/mslice/presenters/main_presenter.py", line 52, in notify_workspace_selection_changed
    self.broadcast_selection_changed()
  File "/home/mlc47243/mambaforge/envs/mantid_env/lib/python3.10/site-packages/mslice/presenters/main_presenter.py", line 49, in broadcast_selection_changed
    listener.workspace_selection_changed()
  File "/home/mlc47243/mambaforge/envs/mantid_env/lib/python3.10/site-packages/mslice/presenters/slice_widget_presenter.py", line 107, in workspace_selection_changed
    if len(workspace_selection) != 1 or not is_sliceable(workspace_selection[0]):
  File "/home/mlc47243/mambaforge/envs/mantid_env/lib/python3.10/site-packages/mslice/models/slice/slice_functions.py", line 52, in is_sliceable
    ws = get_workspace_handle(workspace)
  File "/home/mlc47243/mambaforge/envs/mantid_env/lib/python3.10/site-packages/mslice/models/workspacemanager/workspace_provider.py", line 14, in get_workspace_handle
    raise KeyError('workspace %s could not be found.' % workspace_name)
KeyError: 'workspace MAR21335_Ei60meV_cut(22.124,38.583)_(1) could not be found.'

@cailafinn
Copy link
Contributor

All issues created. No regressions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Manual Tests Only for issues that are unscripted testing tasks during the release period
Projects
None yet
Development

No branches or pull requests

6 participants