Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What happens if old AddGene files disappear of if files change #184

Open
manulera opened this issue Sep 4, 2024 · 1 comment
Open

What happens if old AddGene files disappear of if files change #184

manulera opened this issue Sep 4, 2024 · 1 comment

Comments

@manulera
Copy link
Owner

manulera commented Sep 4, 2024

Related to #182.

Not sure how long the urls of AddGene are kept around, so there's a chance that they will be removed and the source will no longer be possible to be re-run. Also, maybe the sequence / annotation may change. Some way of warning the user that that's the case could be good. May need something in the frontend as well.

@manulera
Copy link
Owner Author

So it happened. The file was accessible for a few days at https://media.addgene.org/snapgene-media/v1.7.9-0-g88a3305/sequences/110162/c1c98803-c8ba-44a6-95b8-d6a94097e36f/addgene-plasmid-65109-sequence-110162.gbk but has now been removed from AddGene (can no longer be accessed).

Unclear what should happen in this case. Perhaps return an updated source with the new url, but a warning would be appropriate maybe?

manulera added a commit that referenced this issue Sep 11, 2024
* closes #121

* mark xfail test for #184. Still dont know what the best would be in this case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant