-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Structured attribution #20
Comments
Is it realistic that TileJSON producers will include attribution in lots of different languages?
👍 |
Maybe not lots, but yes, some developers have requested this functionality in the past. (mapbox/mapbox-gl-js#1485 would be a workaround at the map level.) |
This seems like a perfectly reasonable approach. What's the status of this? |
As explained in mapbox/mapbox-gl-native#2723 (comment), native map controls need attribution information in a format other than HTML source code. We should allow the
attribution
property to be set to something more structured that can be converted to the appropriate data structures on the client side. For example, it could be an array of objects, each with a requiredtitle
property (interpreted as literal text) and an optionalurl
property (for linking):Other considerations:
title
property be localizable? If so, perhaps it should be set to an object mapping ISO 639 language codes to literal strings.short_title
property beside thetitle
property.feedback
property beside theattribution
property. Many TileJSON documents hosted by Mapbox include an “Improve This Map” link alongside copyright statements. Native clients may want to open an alternative map feedback tool (Map feedback view controller mapbox-gl-native#6001); as things stand, they’d have to look for and omit a specific URL. In space-constrained environments, the client may choose to omit feedback items from the attribution UI to ensure that all the legally required copyright statements are visible./cc @kkaefer @jfirebaugh
The text was updated successfully, but these errors were encountered: