Challenges are often kept as active despite having no tasks

[matkoniecz]

see for example https://maproulette.org/browse/challenges/40603

https://maproulette.org/challenge/41154

https://maproulette.org/challenge/40667

[KasperFranz]

Same for https://maproulette.org/browse/challenges/40496

[matkoniecz]

may be caused by changing task state via API, not user interface?

Maybe I trigger it when last task is set to "disabled" not "fixed"?

[matkoniecz]

I got report that it is still a problem. See

https://maproulette.org/browse/challenges/40109

https://maproulette.org/browse/challenges/42290

https://maproulette.org/browse/challenges/42119

which were given as examples.

[ljdelight]

It does look like this is caused by tasks that are Disabled, and that prevents the Challenge from being completed. For challenge 40109: I don't see anything in the UI that indicates disabled tasks; the GET challenge API call response shows a completionPercentage of 100 and yet the challenge remains active; then the GET challenge data shows 12 tasks, 9 fixed, 3 disabled, 11 deleted.

I bet there's some task completion logic that needs to be updated to account for disabled tasks, or perhaps it's intentional and should be more obvious in the UI.

[matkoniecz]

Disabled tasks definitely should not keep a challenge open. If they do, what is the point of having them?

(in fact - what is the point of having both disabled and deleted?)

[mvexel]

disabled may make sense to a challenge author, to have tasks that they temporarily want to have not included but for whatever reason they do not want to delete, because they may want to re-enable them later.

From an end user perspective this status really does not have any meaning.

So what we'll do is

• On the front end, do not count the disabled tasks in the totals. So in the above example, the total task count that the user sees would be 9 and not 12 (separate ticket to be created for that)
• On the backend, once a challenge has only deleted or disabled tasks left, we mark it as completed.