You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
ann_avg_utils has unnecessary input parameter: experiment_longnames
Also, the user pulls things like units out of the module, then puts them back into the model via this API. I would prefer that the routine returns a dictionary of xarray datasets with the units conversion already applied. I am applying the unit conversion post facto:
This routine doesn't seem to actually be computing timeseries, but rather constructing cache file names. I would prefer that the computation happens, if necessary, here.
Must we do any concatenation inside this function? It seems like mission creep.
The text was updated successfully, but these errors were encountered:
Presuming it's not replaced by a broader revision, I think get_ann_means_and_units should be renamed to something like get_timeseries and possibly accept a freq argument.
ann_avg_utils
has unnecessary input parameter:experiment_longnames
Also, the user pulls things like
units
out of the module, then puts them back into the model via this API. I would prefer that the routine returns a dictionary of xarray datasets with the units conversion already applied. I am applying the unit conversion post facto:This routine doesn't seem to actually be computing timeseries, but rather constructing cache file names. I would prefer that the computation happens, if necessary, here.
Must we do any concatenation inside this function? It seems like mission creep.
The text was updated successfully, but these errors were encountered: