You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm not sure if what I'm about to suggest is a good idea, but I was surprised to see zero-population swatches turn up in my results. This is caused by L123 and L133 in Palette:generateEmptySwatches.
Would it be possible (or worthwhile) to include a non-zero population count for generated swatches? One option might be to take the generated color, and re-analyze the image to determine the population of pixels that approximate that color. Another option might be to use the dark swatch population in its stead.
In my implementation, I'm just looking to extract a single dominant color, so if the vibrant color is missing its population, I ignore it and fall back to dark vibrant.
The reason I'm asking is because I'm intending to use the population together with image size to generate a fill percentage, which will be used as a factor in weighing score when searching by color.
I'm not sure if I'm looking for solutions here, but I'd be interested in a discussion. Hopefully, if someone else is confused by zero populations appearing in their results, this will help them track down the cause.
The text was updated successfully, but these errors were encountered:
IllyaMoskvin
added a commit
to art-institute-of-chicago/data-aggregator
that referenced
this issue
Nov 29, 2017
I'm not sure if what I'm about to suggest is a good idea, but I was surprised to see zero-population swatches turn up in my results. This is caused by L123 and L133 in Palette:generateEmptySwatches.
Would it be possible (or worthwhile) to include a non-zero population count for generated swatches? One option might be to take the generated color, and re-analyze the image to determine the population of pixels that approximate that color. Another option might be to use the dark swatch population in its stead.
In my implementation, I'm just looking to extract a single dominant color, so if the vibrant color is missing its population, I ignore it and fall back to dark vibrant.
The reason I'm asking is because I'm intending to use the population together with image size to generate a fill percentage, which will be used as a factor in weighing score when searching by color.
I'm not sure if I'm looking for solutions here, but I'd be interested in a discussion. Hopefully, if someone else is confused by zero populations appearing in their results, this will help them track down the cause.
The text was updated successfully, but these errors were encountered: