Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compatibility with latest Turing versions #12

Closed
thorek1 opened this issue Aug 6, 2023 · 5 comments
Closed

compatibility with latest Turing versions #12

thorek1 opened this issue Aug 6, 2023 · 5 comments

Comments

@thorek1
Copy link

thorek1 commented Aug 6, 2023

Hi,

is there any chance of making MuseInference.jl compatible with the latest Turing version (currently 0.28)?

A lot happened since Turing 0.21.10 and it would greatly benefit my workflow to use later Turing versions.

Thanks

@marius311
Copy link
Owner

Looking into it. Shouldn't be too hard in theory (famous last words).

@marius311
Copy link
Owner

Can you try with #15 and let me know if you run into any issues?

@thorek1
Copy link
Author

thorek1 commented Aug 8, 2023

works fine with 1 thread and latest Turing, not with >1 threads

@marius311
Copy link
Owner

Ok, latest Turing, including ForwardDiff w/ threads, is fixed on latest release (0.2.4). Zygote w/ threads doesn't work, but there's an informative error thrown now at least, that seems to be a bonafide issue on the DynamicPPL side.

@itsdfish
Copy link

itsdfish commented Jun 9, 2024

Thank you for the package. I wanted to chime in and note that this does not work with the current release of Turing 0.33.0. Perhaps adding CompatHelper to gitactions would be a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants