-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to SilverShop 3 / SS4 #7
Comments
Good to hear from you! I haven't had very much time to work on any of these modules lately because I'm not working in PHP or Silverstripe at all. I'll be happy to work with you to get this PR merged and tagged, or happy to add a message on my repo that suggests folks use your fork instead. Whichever you prefer. I do think the |
Hey Mark. Would you mind moving the module to the silvershop organization on github? https://github.com/silvershop/ Hope you and your family are doing well. |
Sure. That makes sense. Is there any value in just pulling it into SilverShop itself as part of the core image functionality? Or would you prefer to leave it out as its own module? |
I'd prefer to keep it as separate module. SilverShop core would ideally be more modular/slim instead of constantly growing with features. |
@markguinn any news on this? I also updated extended pricing module for a project and would be happy to PR / release an updated version. It would be cool if you can transfer the modules to the silvershop organisation, see https://help.github.com/articles/transferring-a-repository-owned-by-your-personal-account/ |
Hi Mark,
I'm currently updating the module to SS4 / SilverShop3, see https://github.com/wernerkrauss/silverstripe-shop-extendedimages/tree/update-to-ss4
are you still maintaining the silvershop modules? Is the "SilverShop" namespace ok or should I use something else?
Any feedback is appreciated.
The text was updated successfully, but these errors were encountered: