Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Marko to browser repaint benchmark "js-repaint-perfs" #993

Closed
maxmilton opened this issue Feb 19, 2018 · 4 comments
Closed

Add Marko to browser repaint benchmark "js-repaint-perfs" #993

maxmilton opened this issue Feb 19, 2018 · 4 comments
Labels
help wanted Not on the core-team's roadmap, but it would be great for someone in the community to tackle it type:community Related to community building, improving the contribution process, etc.

Comments

@maxmilton
Copy link

New Feature

Description

This is not so much a feature request but more of a general suggestion. Add a Marko implementation to https://github.com/mathieuancelin/js-repaint-perfs. js-repaint-perfs is a performance benchmark to test various JS libraries ability to update the DOM.

Why

It's really interesting to see the libraries in a head-to-head benchmark. Would be very interesting to see where Marko slots in, especially since DOM performance is something Marko is touted as being particularly good at.

Could also be a fun way for users to learn more about Marko performance.

Possible Implementation & Open Questions

I'm keen to have a go eventually once I have some time but if someone else beats me to it, it's no prob. It would be a fun quick side project 😄

Is this something you're interested in working on?

Yes

@maxmilton
Copy link
Author

I've also created an issue in the js-repaint-perfs repo for cross reference: mathieuancelin/js-repaint-perfs#127

@maxmilton
Copy link
Author

maxmilton commented Mar 1, 2018

For reference if anyone is interested there's also another head-to-head benchmark over at http://www.stefankrause.net/js-frameworks-benchmark7/table.html. Plus repo at https://github.com/krausest/js-framework-benchmark.

It's particularly interesting as the results are very different to the benchmarks presented on markojs.com, in this benchmark Marko actually falls below many of the popular frameworks.

There's likely opportunity to improve the code over at that benchmark too (for example to submit a non-keyed version).

@mlrawlings mlrawlings added type:community Related to community building, improving the contribution process, etc. help wanted Not on the core-team's roadmap, but it would be great for someone in the community to tackle it labels Mar 6, 2018
@jasonmacdonald
Copy link
Contributor

jasonmacdonald commented Mar 7, 2018

@maxmilton Looking at JS-Paint repo, it doesn't appear to be maintained anymore, or at least not kept up-to-date with current framework versions. I'm not sure how much value there is in trying to get Marko added there.

The js-frameworks-benchmark is certainly more up-to-date and we probably should have a look at what they are doing to ensure it's properly optimized. When looking at their more recent beta version, it clearly shows there's something seriously wrong with their Marko implementation. But, it's also possible they have not yet addressed certain frameworks, so it could change with time.

@vaheqelyan
Copy link

any updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Not on the core-team's roadmap, but it would be great for someone in the community to tackle it type:community Related to community building, improving the contribution process, etc.
Projects
None yet
Development

No branches or pull requests

5 participants