Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest non-silent option in kuenm_ceval #39

Open
weshinsley opened this issue Jan 24, 2022 · 0 comments
Open

Suggest non-silent option in kuenm_ceval #39

weshinsley opened this issue Jan 24, 2022 · 0 comments

Comments

@weshinsley
Copy link

Hi,

I have written a PR including some changes I found necessary for our use case:

  1. We've been evaluating 100,000+ models. We ran all these first on a compute cluster; for reasons we're not quite sure of, some of these failed and needed rerunning - this isn't kuenm_ceval's fault, but it wasn't easy to see in advance whether those models had run correctly or not.

What was difficult with kuenm_ceval was the lack of any debug output, so it wasn't possible to tell whether it was just busy, or had stalled waiting for some unreported model to be valid.

So I added a "silent" option to kuenm_ceval, which is false, outputs what model it is working on, and reports if it is having to wait. I found this totally essential, then I could rerun the models that had previously failed. Possibly this would be relevant to issue #7 and issue #19. After that, I could then call with silent=TRUE to read the output from the cluster log (The sys.sleep(0.1) flushes stdout I think) - and see where/why it had stalled.

  1. I also added a catch for when ku_enm_eval comes through entirely NA, in which case the log plots will fail and our cluster jobs exited prematurely.

Hope that's useful, see
#38

Thanks,
Wes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant