Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pods have a slight error compared to Master #133

Open
osianSmith opened this issue May 26, 2019 · 0 comments
Open

Pods have a slight error compared to Master #133

osianSmith opened this issue May 26, 2019 · 0 comments

Comments

@osianSmith
Copy link

Hey,
Hate to really be picky but on line 98 of Localise.swift it's
if let indexOfBase = availableLanguages.index(of: "Base") , excludeBase == true {
But on master it is
if let indexOfBase = availableLanguages.firstIndex(of: "Base") , excludeBase == true {
index has been depreciated and has been replaced by firstIndex.

It's not really an issue as such but just wanted to mention just in case if there were any other discrepancies between the versions

This library is pretty awesome though and has saved me a massive amount of work getting the Welsh Langauge supported in one of my apps (customer requirement)

Thanks

Osian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant